public inbox for [email protected]help / color / mirror / Atom feed
pg_stash_advice doc 3+ messages / 2 participants [nested] [flat]
* pg_stash_advice doc @ 2026-04-10 09:18 Erik Rijkers <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Erik Rijkers @ 2026-04-10 09:18 UTC (permalink / raw) To: pgsql-hackers; Robert Haas <[email protected]> Hi, The pg_stash_advice doc ( doc/src/sgml/pgstashadvice.sgml ) contains this sentence: "This means both that it is important to be mindful of memory consumption when deciding how much plan advice to stash." It seems to me 'both' should be 'also', or maybe just dropped. Thanks, Erik ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pg_stash_advice doc @ 2026-04-10 15:57 Robert Haas <[email protected]> parent: Erik Rijkers <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Robert Haas @ 2026-04-10 15:57 UTC (permalink / raw) To: Erik Rijkers <[email protected]>; +Cc: pgsql-hackers On Fri, Apr 10, 2026 at 5:18 AM Erik Rijkers <[email protected]> wrote: > "This means both that it is important to be mindful > of memory consumption when deciding how much plan advice to stash." > > It seems to me 'both' should be 'also', or maybe just dropped. Oops. That sentence had a second part in the first pg_stash_advice commit, and the second commit remove the second part of the sentence without remembering to delete the word "both". -- Robert Haas EDB: http://www.enterprisedb.com ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: pg_stash_advice doc @ 2026-04-13 16:54 Robert Haas <[email protected]> parent: Robert Haas <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Robert Haas @ 2026-04-13 16:54 UTC (permalink / raw) To: Erik Rijkers <[email protected]>; +Cc: pgsql-hackers On Fri, Apr 10, 2026 at 11:57 AM Robert Haas <[email protected]> wrote: > On Fri, Apr 10, 2026 at 5:18 AM Erik Rijkers <[email protected]> wrote: > > "This means both that it is important to be mindful > > of memory consumption when deciding how much plan advice to stash." > > > > It seems to me 'both' should be 'also', or maybe just dropped. > > Oops. That sentence had a second part in the first pg_stash_advice > commit, and the second commit remove the second part of the sentence > without remembering to delete the word "both". I have committed a fix. Thanks again for the report. -- Robert Haas EDB: http://www.enterprisedb.com ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-04-13 16:54 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-04-10 09:18 pg_stash_advice doc Erik Rijkers <[email protected]> 2026-04-10 15:57 ` Robert Haas <[email protected]> 2026-04-13 16:54 ` Robert Haas <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox