public inbox for [email protected]  

help / color / mirror / Atom feed

From: Heikki Linnakangas <[email protected]>
To: Lakshmi N <[email protected]>
To: [email protected]
Subject: Re: [PATCH] Fix missing pfree(flags.data) in overexplain_debug
Date: Tue, 14 Apr 2026 12:20:15 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+3i_M9_R4t62NPqoa0pjkffMFzLeU30xGdBV4C-PUGHGh5W=w@mail.gmail.com>
References: <CA+3i_M9_R4t62NPqoa0pjkffMFzLeU30xGdBV4C-PUGHGh5W=w@mail.gmail.com>

On 13/04/2026 23:33, Lakshmi N wrote:
> Hi hackers,
> 
> attached a small patch to fix missing  pfree(flags.data) in 
> overexplain_debug.

These leaks are to a relatively short-lived memory context. We don't 
need to meticulously pfree() those, they will go away with the memory 
context. There are also numerous psprintf() calls in the function and in 
the subroutines which are not pfreed, for example.

We're not totally consistent, as there are pfree() calls in some of the 
subroutines. I don't know if there's some grand plan on when to pfree() 
and when not to bother, but this one pfree() won't move the needle much 
in any case.

- Heikki

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Fix missing pfree(flags.data) in overexplain_debug
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox