From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: additional foreign key test coverage
Date: Fri, 7 Dec 2018 16:52:58 +0100
Message-ID: <89ea748a-a9d7-9c42-276c-a007280ac059@2ndquadrant.com> (raw)
In-Reply-To: <20181204132320.kzismcb7bajz4lvc@alvherre.pgsql>
References: <20181204132320.kzismcb7bajz4lvc@alvherre.pgsql>
On 04/12/2018 14:23, Alvaro Herrera wrote:
> On 2018-Dec-04, Peter Eisentraut wrote:
>
>> During the development of my recent patch "unused/redundant foreign key
>> code" [0], I had developed a few additional test cases to increase the
>> coverage in ri_triggers.c. They are in the attached patches with
>> explanations. With these, coverage should be pretty complete, except
>> hard-to-trigger error cases. Interested reviewers can also follow along
>> on coverage.postgresql.org.
>
> Hmm. One of the things I did for FKs on partitioned tables was remove
> all the cases involving only unpartitioned tables, then run just the
> foreign_key test and see what the coverage looked like -- in the first
> versions, there were large swaths of uncovered code. That guided me to
> add a few more tests to increase coverage in later versions. This is
> all to say that I think it would be useful to include the case of
> partitioned tables in the tests you add, where relevant.
I'm not sure I understand where partitioned tables come in here. In
ri_triggers.c, it's all dealing with single base tables. Certainly
other code elsewhere needs to know about partitions.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, alvherre@2ndquadrant.com
Subject: Re: additional foreign key test coverage
In-Reply-To: <89ea748a-a9d7-9c42-276c-a007280ac059@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox