pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Foreign keys and partitioned tables
Date: Sat, 31 Mar 2018 09:09:01 -0400
Message-ID: <8a3e483c-d89f-6872-74ac-5f0ee36357eb@2ndquadrant.com> (raw)
In-Reply-To: <20180330031953.5j4sspyl6s4rdb62@alvherre.pgsql>
References: <20180330031953.5j4sspyl6s4rdb62@alvherre.pgsql>

On 3/29/18 23:19, Alvaro Herrera wrote:
> 0001 prohibits having foreign keys pointing to partitioned tables, as
> discussed above.

This is already prohibited.  You get an error

ERROR:  cannot reference partitioned table "fk_partitioned_pk"

Your patch 0001 just adds the same error check a few lines above the
existing one, while 0003 removes the existing one.

I think you can squash 0001 and 0003 together.

> 0002 is a fixup for a bug in the row triggers patch: I had a restriction
> earlier that triggers declared internal were not cloned, and I seem to
> have lost it in rebase.  Reinstate it.

Hmm, doesn't cause any test changes?

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




view thread (23+ messages)  latest in thread

Message-ID: <8a3e483c-d89f-6872-74ac-5f0ee36357eb@2ndquadrant.com>
Permalink:  ../8a3e483c-d89f-6872-74ac-5f0ee36357eb@2ndquadrant.com/
Also on:    postgresql.org/message-id/8a3e483c-d89f-6872-74ac-5f0ee36357eb@2ndquadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, alvherre@alvh.no-ip.org
  Subject: Re: Foreign keys and partitioned tables
  In-Reply-To: <8a3e483c-d89f-6872-74ac-5f0ee36357eb@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox