public inbox for [email protected]  

help / color / mirror / Atom feed

From: Brar Piening <[email protected]>
To: Peter Smith <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Karl O. Pinc <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: vignesh C <[email protected]>
Cc: Ian Lawrence Barwick <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: doc: add missing "id" attributes to extension packaging page
Date: Tue, 28 Mar 2023 12:17:28 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHut+Pvvi+dyXb-Gr56dD9xJrckEvopORFmbYr17_GxhekuWtA@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<CAHut+Pvvi+dyXb-Gr56dD9xJrckEvopORFmbYr17_GxhekuWtA@mail.gmail.com>

On 28.03.2023 at 00:11, Peter Smith wrote:
> FYI, there is a lot of overlap between this last attachment and the
> patches of Kuroda-san's current thread here [1] which is also adding
> ids to create_subscription.sgml.
>
> (Anyway, I guess you might already be aware of that other thread
> because your new ids look like they have the same names as those
> chosen by Kuroda-san)
>
> ------
> [1] https://www.postgresql.org/message-id/flat/CAHut%2BPvzo6%3DKKLqMR6-mAQdM%2Bj_dse0eUreGmrFouL7gbLbv2w...

Thanks, I actually was not aware of this.

Also, kudos for capturing the missing id and advocating for consistency
regarding ids even before this is actively enforced. This nurtures my
optimism that consistency might actually be achieveable without
everybody getting angry at me because my patch will enforce it.

Regarding the overlap, I currently try to make it as easy as possible
for a potential committer and I'm happy to rebase my patch upon request
or if Kuroda-san's patch gets applied first.

Regards,

Brar

view thread (35+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: doc: add missing "id" attributes to extension packaging page
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox