public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Dean Rasheed <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: jian he <[email protected]>
Subject: Re: Virtual generated columns
Date: Fri, 7 Feb 2025 13:34:47 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAEZATCVsfdp5MQpENpbrFAAfpC2tYU7y-Q=uOG57UubGy48Gyw@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAEZATCUHnmOu7RtDuP+PCtS_dqvU8hFsAYYFPdiB8gyFszj5WQ@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAEZATCXQcjZPq+OsczFc13M6v+OP_NiqmUAcRAzi1K60KFuWmQ@mail.gmail.com>
	<[email protected]>
	<CAEZATCXnp5XTkUCsmfjLXVWZ7TaibWatnXDdu52J6zN3XsyZhw@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAEZATCX6SHevKrVfAOq+88b4Ysm4Rqq2yeO6He3N0pttEbjYag@mail.gmail.com>
	<[email protected]>
	<CAEZATCVsfdp5MQpENpbrFAAfpC2tYU7y-Q=uOG57UubGy48Gyw@mail.gmail.com>

On 06.02.25 00:25, Dean Rasheed wrote:
> On Tue, 4 Feb 2025 at 22:36, Peter Eisentraut <[email protected]> wrote:
>>
>> Yeah, this is quite contorted.  I have renamed it like you suggested.
> 
> I looked over this again and I think the patch is in good shape to be committed.

I've committed it.  Thanks.

> One thought that occurred to me was whether it would be better for the
> psql describe output (and maybe also pg_dump) to explicitly output
> "virtual" for columns of this kind. I know that that's the default for
> generated columns, but someone reading the output might not know or
> remember that, so perhaps it would be helpful to be explicit.

My preference was to have the default output format use only 
SQL-standard syntax, not extensions like "VIRTUAL".  If people hate 
this, we can easily change it.

view thread (75+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Virtual generated columns
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox