From: Jonathan S. Katz <jkatz@postgresql.org>
To: Andres Freund <andres@anarazel.de>
To: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: John Naylor <john.naylor@enterprisedb.com>
Cc: Amit Langote <amitlangote09@gmail.com>
Subject: Re: SQL/JSON features for v15
Date: Tue, 16 Aug 2022 21:45:06 -0400
Message-ID: <8d0ffc54-469a-ffab-68a3-8b547e24a08d@postgresql.org> (raw)
In-Reply-To: <20220816021425.5sa6gx67zmpou3bc@awork3.anarazel.de>
References: <abd9b83b-aa66-f230-3d6d-734817f0995d@postgresql.org>
<20220815223853.itrlpqgpqheg6r6a@awork3.anarazel.de>
<225d341b-f310-eed0-ceff-b8ec61669d9f@postgrespro.ru>
<20220816021425.5sa6gx67zmpou3bc@awork3.anarazel.de>
Hi,
On 8/15/22 10:14 PM, Andres Freund wrote:
> I pushed a few cleanups to https://github.com/anarazel/postgres/commits/json
> while I was hacking on this (ignore that it's based on the meson tree, that's
> just faster for me). Some of them might not be applicable anymore, but it
> might still make sense for you to look at.
With RMT hat on, this appears to be making progress. A few questions /
comments for the group:
1. Nikita: Did you have a chance to review Andres's changes as well?
2. There seems to be some, though limited, progress on design docs.
Andres keeps making a point on adding additional comments to the code to
make it easier to follow. Please do not lose sight of this.
3. Robert raised a point about the use of subtransactions and the
increased risk of wraparound on busy systems using the SQL/JSON
features. Do these patches help reduce this risk? I read some clarity on
the use of subtransactions within the patchset, but want to better
understand if the risks pointed out are a concern.
Thanks everyone for your work on this so far!
Jonathan
Attachments:
OpenPGP_signature (application/pgp-signature, 839B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jkatz@postgresql.org, andres@anarazel.de, n.gluhov@postgrespro.ru, pgsql-hackers@lists.postgresql.org, andrew@dunslane.net, tgl@sss.pgh.pa.us, michael@paquier.xyz, john.naylor@enterprisedb.com, amitlangote09@gmail.com
Subject: Re: SQL/JSON features for v15
In-Reply-To: <8d0ffc54-469a-ffab-68a3-8b547e24a08d@postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox