pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: TAP tests and symlinks on Windows
Date: Sun, 5 Jul 2020 08:18:46 -0400
Message-ID: <90193559-efe2-cb43-888a-52f964b931fc@2ndQuadrant.com> (raw)
In-Reply-To: <504f09d7-d600-44ca-a32b-0ed209cc2273@2ndquadrant.com>
References: <87sgf4pmb8.fsf@wibble.ilmari.org>
	<20200612065957.GA3362@paquier.xyz>
	<CAC+AXB0VJ9A4f6Ob9b3wV8V_VGND5X3MBLKQRd0+8L6t-gMiCQ@mail.gmail.com>
	<20200613060054.GM3362@paquier.xyz>
	<20200615062319.GF52676@paquier.xyz>
	<11c4ee09-3706-5912-ffd7-dc3657de7a5e@2ndQuadrant.com>
	<20200617074434.GB118592@paquier.xyz>
	<20200623105527.GA1974@paquier.xyz>
	<3ebcde2b-3b78-2e5f-9249-03c709dc23dd@2ndquadrant.com>
	<20200629075616.GC330401@paquier.xyz>
	<20200630121328.GB67289@paquier.xyz>
	<504f09d7-d600-44ca-a32b-0ed209cc2273@2ndquadrant.com>


On 7/3/20 10:11 AM, Peter Eisentraut wrote:
> On 2020-06-30 14:13, Michael Paquier wrote:
>> Attached is an updated patch, where I have tried to use a better
>> wording in all the code paths involved.
>
> This new patch doesn't work for me on MSYS2 yet.
>
> It fails right now in 010_pg_basebackup.pl at
>
>     my $realTsDir      = TestLib::perl2host("$shorter_tempdir/tblspc1");
>
> with chdir: No such file or directory.  Because perl2host requires the
> parent directory of the argument to exist, but here it doesn't.
>
> If I add
>
>     mkdir $shorter_tempdir;
>
> above it, then it proceeds past that point, but then the CREATE
> TABLESPACE command fails with No such file or directory.  I think the
> call
>
>     symlink "$tempdir", $shorter_tempdir;
>
> creates a directory inside $shorter_tempdir, since it now exists, per
> my above change, rather than in place of $shorter_tempdir.
>
> I think all of this is still a bit too fragile it needs further
> consideration.



I'll see what I can come up with.


cheers


andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services






view thread (34+ messages)  latest in thread

Message-ID: <90193559-efe2-cb43-888a-52f964b931fc@2ndQuadrant.com>
Permalink:  ../90193559-efe2-cb43-888a-52f964b931fc@2ndQuadrant.com/
Also on:    postgresql.org/message-id/90193559-efe2-cb43-888a-52f964b931fc@2ndQuadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andrew.dunstan@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, michael@paquier.xyz, juanjo.santamaria@gmail.com, ilmari@ilmari.org
  Subject: Re: TAP tests and symlinks on Windows
  In-Reply-To: <90193559-efe2-cb43-888a-52f964b931fc@2ndQuadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox