pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Joe Conway <mail@joeconway.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: PG 14 release notes, first draft
Date: Tue, 11 May 2021 15:51:39 -0400
Message-ID: <904085.1620762699@sss.pgh.pa.us> (raw)
In-Reply-To: <30b83e29-76c7-d925-b517-26c530204630@joeconway.com>
References: <20210510060308.GC6088@momjian.us>
	<1ff33728-e912-2006-6864-c99abbc99603@joeconway.com>
	<20210511015645.GL6088@momjian.us>
	<e507bfe1-9d04-fae5-15eb-d1a1796de03d@joeconway.com>
	<20210511151120.GS6088@momjian.us>
	<d50310b7-dc7f-f4c9-26e2-0896c150221e@joeconway.com>
	<20210511153702.GU6088@momjian.us>
	<bb7ce6aa-ef16-7725-c742-9edb5ac2dacb@joeconway.com>
	<20210511173014.GV6088@momjian.us>
	<30b83e29-76c7-d925-b517-26c530204630@joeconway.com>

Joe Conway <mail@joeconway.com> writes:
> On 5/11/21 1:30 PM, Bruce Momjian wrote:
>> It just feels like this change makes the function's behavior less
>> consistent.

> See Tom's commit message here:
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=3d0f68dd30612

> In particular:

>    "The variants of these functions that take
>     numeric inputs (OIDs or column numbers) are
>     supposed to return NULL rather than failing
>     on bad input; this rule reduces problems with
>     snapshot skew when queries apply the functions
>     to all rows of a catalog."

Yeah, the null-return-for-bad-numeric-input behavior is important.
Perhaps a case could be made for returning null for bad text
input too, but I don't recall that anybody has asked for that.

A case could also be made that changing the behavior on the text
side would break applications that expect the current behavior.
So I'm disinclined to make a wholesale change there, without more
evidence that it's a good idea.

			regards, tom lane





view thread (173+ messages)  latest in thread

Message-ID: <904085.1620762699@sss.pgh.pa.us>
Permalink:  ../904085.1620762699@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/904085.1620762699@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, mail@joeconway.com, bruce@momjian.us
  Subject: Re: PG 14 release notes, first draft
  In-Reply-To: <904085.1620762699@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox