pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org, Thomas Munro <thomas.munro@gmail.com>
Subject: Re: failures in t/031_recovery_conflict.pl on CI
Date: Tue, 12 Apr 2022 15:05:22 -0400
Message-ID: <907760.1649790322@sss.pgh.pa.us> (raw)
In-Reply-To: <20220412184913.3wrt4olkdiqvicsj@alap3.anarazel.de>
References: <20220409045515.35ypjzddp25v72ou@alap3.anarazel.de>
	<20220409050501.frejv2i46m54keem@alap3.anarazel.de>
	<20220409220054.fqn5arvbeesmxdg5@alap3.anarazel.de>
	<20220409231002.mddrr7mtca7p55v5@alap3.anarazel.de>
	<20220409233107.v7okovwr46xsizfk@alap3.anarazel.de>
	<5111.1649547266@sss.pgh.pa.us>
	<20220412184913.3wrt4olkdiqvicsj@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2022-04-09 19:34:26 -0400, Tom Lane wrote:
>> +1.  This is probably more feasible given the latch infrastructure
>> than it was when that code was first written.

> What do you think about just reordering the disable_all_timeouts() to be
> before the got_standby_deadlock_timeout check in the back branches? I think
> that should close at least the most obvious hole.  And fix it properly in
> HEAD?

I don't have much faith in that, and I don't see why we can't fix it
properly.  Don't we just need to have the signal handler set MyLatch,
and then do the unsafe stuff back in the "if (got_standby_deadlock_timeout)"
stanza in mainline?

			regards, tom lane





view thread (38+ messages)  latest in thread

Message-ID: <907760.1649790322@sss.pgh.pa.us>
Permalink:  ../907760.1649790322@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/907760.1649790322@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, thomas.munro@gmail.com
  Subject: Re: failures in t/031_recovery_conflict.pl on CI
  In-Reply-To: <907760.1649790322@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox