pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Noah Misch <noah@leadboat.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-hackers@postgresql.org
Subject: Re: PL_stashcache, or, what's our minimum Perl version?
Date: Mon, 31 Jul 2017 15:17:36 -0400
Message-ID: <90a92a7d-938e-507a-3bd7-ecd2b4004689@2ndquadrant.com> (raw)
In-Reply-To: <9072.1501527316@sss.pgh.pa.us>
References: <20540.1501210115@sss.pgh.pa.us>
	<16894.1501392088@sss.pgh.pa.us>
	<20170730154814.GA2636941@rfd.leadboat.com>
	<22744.1501430710@sss.pgh.pa.us>
	<20170730163054.GA2630977@rfd.leadboat.com>
	<25937.1501433410@sss.pgh.pa.us>
	<c3ad3515-64e9-f5a1-1f39-d2cb646fcb96@2ndquadrant.com>
	<9072.1501527316@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 7/31/17 14:55, Tom Lane wrote:
>> We use the "PATH" variants when we need a fully qualified name.  For
>> example, at some point or another, we needed to substitute a fully
>> qualified perl binary name into the headers of scripts.
> 
>> If there is no such requirement, then we should use the non-PATH variants.
> 
> Why?  That risks failures of various sorts, and you have not stated
> any actual benefit of it.

What I wrote is merely a description of the current practice.  That
practice was in turn developed out of ancient Autoconf standard
practices.  There are arguments to be made for doing it differently.

One major PITA with the AC_PATH_* checks is that you can only override
them with environment variables that are full paths; otherwise the
environment variables are ignored.  For example, currently, running

./configure PYTHON=python3

will result in the PYTHON setting being ignored.  Currently, this only
affects a small number of variables, but if we expanded that, it would
be a pretty significant usability change.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (30+ messages)  latest in thread

Message-ID: <90a92a7d-938e-507a-3bd7-ecd2b4004689@2ndquadrant.com>
Permalink:  ../90a92a7d-938e-507a-3bd7-ecd2b4004689@2ndquadrant.com/
Also on:    postgresql.org/message-id/90a92a7d-938e-507a-3bd7-ecd2b4004689@2ndquadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, noah@leadboat.com, andrew@dunslane.net
  Subject: Re: PL_stashcache, or, what's our minimum Perl version?
  In-Reply-To: <90a92a7d-938e-507a-3bd7-ecd2b4004689@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox