public inbox for [email protected]  

help / color / mirror / Atom feed

From: ahmedashour <[email protected]>
To: [email protected]
Subject: [PATCH] [52] Review of patch 5381 - Documentation for pgstatindex fragmentation
Date: Thu, 27 Feb 2025 01:23:07 +0200
Message-ID: <[email protected]> (raw)

Hi all,

I’m a beginner contributor reviewing patch 5381 from Commitfest 52.
Here’s my feedback:

- Applied the patch to the master branch (as of Feb 26, 2025) using
`patch -p1 < 5381.patch`.
- It updates doc/src/sgml/pgstattuple.sgml, adding a paragraph about
`leaf_fragmentation`.
- Built the HTML docs with `make html` in the doc directory and
reviewed the output in a browser.
- The new text explains that `leaf_fragmentation` is the percentage of
fragmented leaf pages in an index, caused by deletions/updates, and
mentions performance impacts and REINDEX as maintenance.
- The explanation is clear and accurate. No formatting issues or typos
found in the HTML output.
- Suggestion: Adding a simple example like “A value of 30% means 30% of
leaf pages have gaps” could make it even more beginner-friendly.

Overall, it looks solid and ready for committer review. Thanks to
Frédéric Yhuel for this useful addition!

Regards,
[Ahmed Ashour]

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: [PATCH] [52] Review of patch 5381 - Documentation for pgstatindex fragmentation
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox