From: Tom Lane <tgl@sss.pgh.pa.us>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Nisha Moond <nisha.moond412@gmail.com>
Cc: Euler Taveira <euler@eulerto.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alexander Lakhin <exclusion@gmail.com>
Cc: Jonathan S. Katz <jkatz@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Large expressions in indexes can't be stored (non-TOASTable)
Date: Mon, 28 Apr 2025 18:19:19 -0400
Message-ID: <910625.1745878759@sss.pgh.pa.us> (raw)
In-Reply-To: <aA_4S5ZBaI_Qje2s@nathan>
References: <18a111db-9f31-449c-a14b-61779a69f344@app.fastmail.com>
<Z_mHvqVyGjEZhzl7@nathan>
<aAZqiKRhUv7-fSpQ@nathan>
<CABdArM6j03AAX5A2B9TPCZrY1xr+eFpGpzfdOBAww7mZnniUFg@mail.gmail.com>
<aAfP_bitjVC1bcNV@nathan>
<aAla1fg-1vPeXNck@nathan>
<1503201.1745444021@sss.pgh.pa.us>
<aAlfU06XTChyIGBD@nathan>
<aA_zMYasoUwNrDx1@nathan>
<905635.1745876108@sss.pgh.pa.us>
<aA_4S5ZBaI_Qje2s@nathan>
Nathan Bossart <nathandbossart@gmail.com> writes:
> On Mon, Apr 28, 2025 at 05:35:08PM -0400, Tom Lane wrote:
>> Possibly better idea: can we add something like
>> Assert(!OidIsValid(reltoastrelid)) in the code that is making this
>> assumption?
> Yeah, we could add something like that to replorigin_create() pretty
> easily. The comment for that would be even harder to miss.
Maybe one more sentence in the code comment so that the logic is
easier to follow:
+ /*
+ * We want to be able to access pg_replication_origin without setting up a
+ * snapshot. To make that safe, it needs to not have a TOAST table,
+ * since TOASTed data cannot be fetched without a snapshot. As of this
+ * writing, ...
LGTM other than that nit.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, nathandbossart@gmail.com, nisha.moond412@gmail.com, euler@eulerto.com, michael@paquier.xyz, amit.kapila16@gmail.com, exclusion@gmail.com, jkatz@postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: Large expressions in indexes can't be stored (non-TOASTable)
In-Reply-To: <910625.1745878759@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox