public inbox for [email protected]  

help / color / mirror / Atom feed

From: Alexander Lakhin <[email protected]>
To: Alexander Korotkov <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: Daniel Shelepanov <[email protected]>
Cc: Nikita Malakhov <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Andres Freund <[email protected]>
Subject: Re: collect_corrupt_items_vacuum.patch
Date: Mon, 4 Dec 2023 13:00:00 +0300
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAPpHfdt8Rj_LtG8aWKNzeRejutrN-zt6fKQGuXYyAE7-zNVHbg@mail.gmail.com>
References: <[email protected]>
	<CA+TgmoZtw7yNZogHFrgatHnvc2rOX9hoRRq=GtUBZx9mxh86Vg@mail.gmail.com>
	<[email protected]>
	<CA+TgmoYmGN6ivwioc4YaEQqGOS2oH=0jDYMVghb6Vd5hx6bwtA@mail.gmail.com>
	<[email protected]>
	<CAN-LCVMLrup6=6yGxrMVThPrNYpa4km7Nn420PaFVo3sRjxpbw@mail.gmail.com>
	<CAN-LCVMWxCvraFrGWxMtvkqrkSYZhCoOixR8a2sOjSCgG_pgrw@mail.gmail.com>
	<[email protected]>
	<CAPpHfdu6c=dQHq4r_xXbcAu0T4P28wv6x7QTwBZa7idv6nZsrA@mail.gmail.com>
	<[email protected]>
	<CAPpHfdsVVAdaGAJgoOBAJ+6EGaCdsUi=wbgQAc3+8X_qtUr=Qg@mail.gmail.com>
	<[email protected]>
	<CAPpHfdt8Rj_LtG8aWKNzeRejutrN-zt6fKQGuXYyAE7-zNVHbg@mail.gmail.com>

Hi Alexander,

04.12.2023 03:23, Alexander Korotkov wrote:
> I managed to reproduce this on a Linux VM.  This problem should arise
> because in extension I don't have access to ProcArrayStruct.  So, my
> code is iterating the whole PGPROC's array.  I reimplemented the new
> horizon calculation function in the core with usage of
> ProcArrayStruct.  Now it doesn't fall for me.  Please, recheck.

Yes, v4 works for me as well (thousands of iterations passed).
Thank you!

Though the test passes even without manipulations with the PROC_IN_VACUUM
flag in pg_visibility.c (maybe the test is not good enough to show why
those manipulations are needed).
I also couldn't see where VISHORIZON_DATA_STRICT comes into play...

Best regards,
Alexander

view thread (15+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: collect_corrupt_items_vacuum.patch
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox