public inbox for [email protected]  

help / color / mirror / Atom feed

From: Tom Lane <[email protected]>
To: Robert Haas <[email protected]>
Cc: Hao Zhang <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] plpython function causes server panic
Date: Fri, 22 Mar 2024 11:51:00 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmoZpk+dXtNDLvfO9MdJzMh-RCjJS3_SE7+jT0URCdSGeVg@mail.gmail.com>
References: <CALY6Dr-2yLVeVPhNMhuBnRgOZo1UjoTETgtKBx1B2gUi8yy+3g@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CALY6Dr8fPasw5DP3FFD2YjRZMKeX9_Ank14tz_bmPjjqLB1U7g@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CA+TgmoZpk+dXtNDLvfO9MdJzMh-RCjJS3_SE7+jT0URCdSGeVg@mail.gmail.com>

Robert Haas <[email protected]> writes:
> On Fri, Dec 29, 2023 at 12:56 PM Tom Lane <[email protected]> wrote:
>> Here's a draft patch along this line.  Basically the idea is that
>> subtransactions used for error control are now legal in parallel
>> mode (including in parallel workers) so long as they don't try to
>> acquire their own XIDs.  I had to clean up some error handling
>> in xact.c, but really this is a pretty simple patch.

> I agree with the general direction. A few comments:

Thanks for looking at this!  I was hoping you'd review it, because
I thought there was a pretty significant chance that I'd missed some
fundamental reason it couldn't work.  I feel better now about it
being worth pursuing.

I consider the patch draft quality at this point: I didn't spend
much effort on docs or comments, and none on test cases.  I'll
work on those issues and come back with a v2.

			regards, tom lane

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] plpython function causes server panic
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox