From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: ALTER TABLE on system catalogs
Date: Fri, 13 Jul 2018 11:05:10 +0200
Message-ID: <920b7cde-6926-4ad3-936b-7637f0a8188f@2ndquadrant.com> (raw)
In-Reply-To: <9fb22a98-fd64-1426-a4f4-b927ce1a9a5e@2ndquadrant.com>
References: <e49f825b-fb25-0bc8-8afc-d5ad895c7975@2ndquadrant.com>
<20180627203733.bfpibxdleimvwdg2@alap3.anarazel.de>
<20180627230838.GI2667@paquier.xyz>
<9fb22a98-fd64-1426-a4f4-b927ce1a9a5e@2ndquadrant.com>
On 28.06.18 10:14, Peter Eisentraut wrote:
> On 6/28/18 01:10, Michael Paquier wrote:
>> On Wed, Jun 27, 2018 at 01:37:33PM -0700, Andres Freund wrote:
>>> On 2018-06-27 22:31:30 +0200, Peter Eisentraut wrote:
>>>> I propose that we instead silently ignore attempts to add TOAST tables
>>>> to shared and system catalogs after bootstrapping.
>>>
>>> That seems like an extremely bad idea to me. I'd rather go ahead and
>>> just add the necessary toast tables than silently violate preconditions
>>> that code assumes are fulfilled.
>>
>> Agreed. Joe Conway was working on a patch to do exactly that. I was
>> personally looking for the possibility of having one with pg_authid in
>> v12 :)
>
> OK, that would change things a bit, in that the silent addition of a
> TOAST table would no longer be a problem, but it wouldn't fix the other
> scenarios that end up in an error. If such a patch is forthcoming, we
> can revisit this again afterwards.
After reviewing that thread, I think my patch would still be relevant.
Because the pending proposal is to not add TOAST tables to some catalogs
such as pg_attribute, so my original use case of allowing ALTER TABLE /
SET on system catalogs would still be broken for those tables.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, michael@paquier.xyz, andres@anarazel.de
Subject: Re: ALTER TABLE on system catalogs
In-Reply-To: <920b7cde-6926-4ad3-936b-7637f0a8188f@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox