pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Amit Langote <amitlangote09@gmail.com>
To: Arne Roland <A.Roland@index.de>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: a misbehavior of partition row movement (?)
Date: Wed, 20 Jan 2021 08:13:50 +0100
Message-ID: <9288ff8b-3b6f-4ab5-e1a0-b9cff1a6d466@enterprisedb.com> (raw)
In-Reply-To: <CA+HiwqEmfjhL5HW8m7Y3ZDW-SFTZw2bTDicN7_1vN9Diew_BgQ@mail.gmail.com>
References: <CA+HiwqFvkBCmfwkQX_yBqv2Wz8ugUGiBDxum8=WvVbfU1TXaNg@mail.gmail.com>
	<CA+HiwqHoSSUzZopd5W29VBBu3EVsb3OfXikeS3K9-qh63kBbyA@mail.gmail.com>
	<dde1b71053e048e9acccc31c69f04050@index.de>
	<CA+HiwqEmfjhL5HW8m7Y3ZDW-SFTZw2bTDicN7_1vN9Diew_BgQ@mail.gmail.com>

On 2021-01-08 09:54, Amit Langote wrote:
>>> I don't quite recall if the decision to implement it like this was
>>> based on assuming that this is what users would like to see happen in
>>> this case or the perceived difficulty of implementing it the other way
>>> around, that is, of firing AFTER UPDATE triggers in this case.
>> I tried to look that up, but I couldn't find any discussion about this. Do you have any ideas in which thread that was handled?
> It was discussed here:
> 
> https://www.postgresql.org/message-id/flat/CAJ3gD9do9o2ccQ7j7%2BtSgiE1REY65XRiMb%3DyJO3u3QhyP8EEPQ%4...
> 
> It's a huge discussion, so you'll have to ctrl+f "trigger" to spot
> relevant emails.  You might notice that the developers who
> participated in that discussion gave various opinions and what we have
> today got there as a result of a majority of them voting for the
> current approach.  Someone also said this during the discussion:
> "Regarding the trigger issue, I can't claim to have a terribly strong
> opinion on this. I think that practically anything we do here might
> upset somebody, but probably any halfway-reasonable thing we choose to
> do will be OK for most people." So what we've got is that
> "halfway-reasonable" thing, YMMV. :)

Could you summarize here what you are trying to do with respect to what 
was decided before?  I'm a bit confused, looking through the patches you 
have posted.  The first patch you posted hard-coded FK trigger OIDs 
specifically, other patches talk about foreign key triggers in general 
or special case internal triggers or talk about all triggers.





view thread (73+ messages)  latest in thread

Message-ID: <9288ff8b-3b6f-4ab5-e1a0-b9cff1a6d466@enterprisedb.com>
Permalink:  ../9288ff8b-3b6f-4ab5-e1a0-b9cff1a6d466@enterprisedb.com/
Also on:    postgresql.org/message-id/9288ff8b-3b6f-4ab5-e1a0-b9cff1a6d466@enterprisedb.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, amitlangote09@gmail.com, A.Roland@index.de, tomas.vondra@2ndquadrant.com, david.g.johnston@gmail.com
  Subject: Re: a misbehavior of partition row movement (?)
  In-Reply-To: <9288ff8b-3b6f-4ab5-e1a0-b9cff1a6d466@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox