public inbox for [email protected]  

help / color / mirror / Atom feed

From: David E. Wheeler <[email protected]>
To: Florents Tselai <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Chao Li <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Alexander Korotkov <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: jian he <[email protected]>
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part
Date: Sat, 31 Jan 2026 11:31:08 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+v5N40aRmC3DYzWDxTbQKMKohkTdMZJ92Nuaj_NniKS7RHpEA@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<CACJufxGAmcwq33nr_MmgnGdGo7E10c55kCA22DQ4n9FBUOZmTA@mail.gmail.com>
	<[email protected]>
	<CACJufxEphbmEWLKzYNfzsyEB5+bkbMAMUHJq2LxpDdcSZn98BA@mail.gmail.com>
	<CACJufxGdgxyRLd03wM=GtJzUskXnXxEBGGtwA2vsTvkV827SxA@mail.gmail.com>
	<CACJufxHxWKhNcTsmYz428yxUikeUVZz=o6mLNRXpB7F_1oDEng@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CA+v5N40aRmC3DYzWDxTbQKMKohkTdMZJ92Nuaj_NniKS7RHpEA@mail.gmail.com>

On Jan 31, 2026, at 11:23, Florents Tselai <[email protected]> wrote:

> I think your attachment was left behind. Attaching it myself (that's v17, right? ) checked out from your PR

Bah! Yes, thank you.

> With the refactoring you’ve done across the parser and executor, 
> I’m already tempted to slip in a few more string methods - but I think we should leave that for a future iteration.
> Functionally, it’d just mean adding another branch in executeStringInternalMethod, 
> and I’d rather keep this patch focused.  

Agreed.

> At this point, I’d say it’s ready for committer review. 
> 
> That said, I do expect someone to raise (again) the question of 
> how we want to handle potential future conflicts with the SQL/JSON standard. 
> That’s a broader design topic, and it’s going to come up every time we extend the JSONPath language.

Yup, continual challenge, part of the deal IME.

> And yes, I’m obviously biased here - I already have two other patches in the same spirit queued up, namely
> https://commitfest.postgresql.org/patch/6429/ 
> https://commitfest.postgresql.org/patch/6436/

Ha! Message received, I’ll try to find some time to look at them.

D



Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

view thread (12+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox