From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Aleksander Alekseev <a.alekseev@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH] Add a few suppression rules for Valgrind
Date: Tue, 20 Feb 2018 12:39:37 -0500
Message-ID: <9335.1519148377@sss.pgh.pa.us> (raw)
In-Reply-To: <20180220172858.ol7rndl6o7sh3qvr@alap3.anarazel.de>
References: <20180220150838.GD18315@e733.localdomain>
<20180220172858.ol7rndl6o7sh3qvr@alap3.anarazel.de>
Andres Freund <andres@anarazel.de> writes:
>> I decided to run the code from master branch under Valgrind and
>> discovered that it reports some errors.
> On my systems I just include a global valgrind suppression file which
> includes libc specific things and then the postgres valgrind.supp. I'm
> very hesitant to add suppressions to the codebase for this, seems too
> likely to actually hide bugs.
Yeah, I think it's a much better idea to add a local suppression file
for problems in your local libc or other libraries. That's what I do.
Looking at mine, it also suppresses some weirdnesses in RHEL6's version
of Perl, which would surely be inappropriate on other platforms.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, a.alekseev@postgrespro.ru
Subject: Re: [PATCH] Add a few suppression rules for Valgrind
In-Reply-To: <9335.1519148377@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox