pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Subject: Re: file cloning in pg_upgrade and CREATE DATABASE
Date: Thu, 8 Nov 2018 08:27:46 +0100
Message-ID: <9391db04-401c-df5f-bbed-48397f9e1798@2ndquadrant.com> (raw)
In-Reply-To: <21210.1541613795@sss.pgh.pa.us>
References: <20181003014409.GC2609@paquier.xyz>
	<20181003020706.hykmk4vmy6brovoj@alvherre.pgsql>
	<20181010195002.GA7806@momjian.us>
	<325b5baf-adcc-9954-2a55-d67b4f3155f0@2ndquadrant.com>
	<d4bc3dae-fdea-2407-5629-cac68be893a3@2ndquadrant.com>
	<20181018235046.GA2099@paquier.xyz>
	<98287e67-0f94-d962-e550-bd169a737181@2ndquadrant.com>
	<21210.1541613795@sss.pgh.pa.us>

On 07/11/2018 19:03, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> Committed, thanks.
> 
> It seems unfortunate that there is no test coverage in the committed
> patch.  I realize that it may be hard to test given the filesystem
> dependency, but how will we know if it works at all?

You can use something like

PG_UPGRADE_OPTS=--clone make -C src/bin/pg_upgrade check

(--link is similarly untested.)

If we do get the TAP tests for pg_upgrade set up, we can create smaller
and faster test cases for this.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

view thread (42+ messages)

Message-ID: <9391db04-401c-df5f-bbed-48397f9e1798@2ndquadrant.com>
Permalink:  ../9391db04-401c-df5f-bbed-48397f9e1798@2ndquadrant.com/
Also on:    postgresql.org/message-id/9391db04-401c-df5f-bbed-48397f9e1798@2ndquadrant.com

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, michael@paquier.xyz, bruce@momjian.us, alvherre@2ndquadrant.com
  Subject: Re: file cloning in pg_upgrade and CREATE DATABASE
  In-Reply-To: <9391db04-401c-df5f-bbed-48397f9e1798@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox