pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Jeevan Ladhe <jeevan.ladhe@enterprisedb.com>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: tushar <tushar.ahuja@enterprisedb.com>
Subject: Re: refactoring basebackup.c
Date: Mon, 08 Nov 2021 10:59:16 -0500
Message-ID: <946660.1636387156@sss.pgh.pa.us> (raw )
In-Reply-To: <CA+TgmoZxO_PQXV=pbgAWSoNTQv8gufH-cX-qMZF7vuzs+T8P6w@mail.gmail.com >
References: <CA+TgmoZGwR=ZVWFeecncubEyPdwghnvfkkdBe9BLccLSiqdf9Q@mail.gmail.com >
<CA+TgmoZBqs7KkyBUFzXQaztuonKanuOV+f_7DYsHOpJs=0B2DA@mail.gmail.com >
<CA+TgmoY5zpS=gJj2O0PXi6YGao5YR89v0qN_xZzWNvff2Tug+Q@mail.gmail.com >
<58D2BD01-B541-4032-9C0B-B6143841E7ED@enterprisedb.com >
<CA+TgmoYgVN=-Yoh71r3P9N7eKysd7_9b9s+1QFfFcs3w7Z-tig@mail.gmail.com >
<CAOgcT0NqC3wNZ=sZWZ252xk6Q=BU_aeEMHE7FeiaP473FzTkgg@mail.gmail.com >
<CA+TgmoaDEBWWxvyL0RZq8kJ9qu1fpJjqn=e7YK3SUB5UBnmTVQ@mail.gmail.com >
<CAOgcT0Nm9TfigWttAaVdQrydz-SrLQRwSEeqzm6mRU-jUmKJnA@mail.gmail.com >
<CA+TgmoYt_v4RUMCQK8dXP7yFezaecFjZw9XDq1i+F=6YnnFxGg@mail.gmail.com >
<CAOgcT0PdvW1aV+Pnim-NuqDxU3zkN4EkQJ1Op9ZVKOssuWBQkw@mail.gmail.com >
<CA+TgmoaW-oxN-xPFvoHdkJxe2zUG3Srw-LGMwwQfEHkJX3wR8w@mail.gmail.com >
<CAOgcT0Orx1jC=hfUPHz_MgtPh6uZjV0p8vzNX2sQo03f8rwmuw@mail.gmail.com >
<CA+TgmoYGuZ49hCfs6Z5jYT7wjQJAP2jrNjJH5qSf9UNQVNJEoQ@mail.gmail.com >
<CAOgcT0NjU__N14G=OwzeXCewFef8T5NCc=uHY9ifMwh_p8HjEA@mail.gmail.com >
<CAOgcT0MNhJFWRBWLAYkOd4! RcO9s7BKfdpy2txf=pC2SRA0JrxQ@mail.gmail.com >
<CA+TgmoYT4FmncwD2t8p_=5E9hTqvANrek2avB-1tip9yJQ9c_Q@mail.gmail.com >
<CAOgcT0OarU7csuf6Obgmg96DdjpGKUSETx5d6ss3eJx7VD+bdA@mail.gmail.com >
<CA+TgmoZEzVs5s-Y-mCMb=pABTdaney=EgipH575z4b3Q=+oW+A@mail.gmail.com >
<CAOgcT0N1zxV0swyR3hDVVXjvun-zO1HhDx4+_F4nUiMv4RiUNw@mail.gmail.com >
<CA+Tgmob6K9u+YOtpK56L1q6q4JnO6B0_N577X60TzVmi8fyC3A@mail.gmail.com >
<CA+TgmobnZT4JKVNfAhWru951HA8P7SBNdCbJvCxAXu0=2+6WdA@mail.gmail.com >
<CAOgcT0P0OGFfNhCKRUyV-rGMXk+JnsYUKGF3tPYhog2c1EQAmg@mail.gmail.com >
<CA+TgmoY_kqYZdpuXLvcX9wj=8Lq6votwT-UJyMDE0btkOTyiWQ@mail.gmail.com >
<CAOgcT0OeWuX+O=-5OTL8VWdjCaCh0HKDoKHDRq1zUfUrdXCnsw@mail.gmail.com >
<CA+TgmoZvqk7UuzxsX1xjJRmMGkqoUGYTZLDCH8SmU1xTPr1Xig@mail.gmail.com >
<CA+TgmobrOXbDh+hCzzVkD3weV3R-QRy3SPa=FRb_Rv9wF5iPJw@mail.gmail.com >
<CA+TgmoZxO_PQXV=pbgAWSoNTQv8gufH-cX-qMZF7vuzs+T8P6w@mail.gmail.com >
Robert Haas <robertmhaas@gmail.com> writes:
> It turns out that these commits are causing failures on prairiedog.
> Per email from Tom off-list, that's apparently because prairiedog has
> a fussy version of tar that doesn't like it when you omit the trailing
> NUL blocks that are supposed to be part of a tar file.
FTR, prairiedog is green. It's Noah's AIX menagerie that's complaining.
It's actually a little bit disturbing that we're only seeing a failure
on that one platform, because that means that nothing else is anchoring
us to the strict POSIX specification for tarfile format. We knew that
GNU tar is forgiving about missing trailing zero blocks, but apparently
so is BSD tar.
One part of me wants to add some explicit test for the trailing blocks.
Another says, well, the *de facto* tar standard seems not to require
the trailing blocks, never mind the letter of POSIX --- so when AIX
dies, will anyone care anymore? Maybe not.
regards, tom lane
view thread (171+ messages) latest in thread
Message-ID: <946660.1636387156@sss.pgh.pa.us>
Permalink: ../946660.1636387156@sss.pgh.pa.us/
Also on: postgresql.org/message-id/946660.1636387156@sss.pgh.pa.us
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, jeevan.ladhe@enterprisedb.com, mark.dilger@enterprisedb.com, tushar.ahuja@enterprisedb.com
Subject: Re: refactoring basebackup.c
In-Reply-To: <946660.1636387156@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox