public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrew Dunstan <[email protected]>
To: Tom Lane <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Jakub Wartak <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: scalability bottlenecks with (many) partitions (and more)
Date: Tue, 4 Mar 2025 17:51:59 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<ffiwtzc6vedo6wb4gbwelon5nefqg675t5c7an2ta7pcz646cg@qwmkdb3l4ett>
<[email protected]>
<5xahykogf2sg3ofdqk2li7xx3t2vh23m42jnvfwxoi5fhh7iya@girlhoxdxjzc>
<[email protected]>
<vgtms7b5egxdypmknxpobocqton3puhprk3ahhk45rcx4uyl33@6uetxejsc75r>
<[email protected]>
<[email protected]>
<nubyc3twqd7mtuyc2rbbt2yazjzbat6mlpfgxtb2ppv2egci3g@uvptf7xmh46m>
<[email protected]>
<qdvrgej743lcddjnb4lzyakt3f5bs2oz34r274wbmgc2g4474q@utqqrqiih65h>
<[email protected]>
<[email protected]>
<[email protected]>
On 2025-03-04 Tu 5:28 PM, Tom Lane wrote:
> Andrew Dunstan<[email protected]> writes:
>> I think I found a logic bug. Testing.
> Not sure what you are looking at, but I was trying to fix it
> by making the loop over test modules skip unbuilt modules,
> borrowing the test you added in v19 to skip unbuilt contrib
> modules. It's a little more complicated for the other modules
> because some of them have no .c files to be built, and I could
> not get that to work. I eventually concluded that there's
> something wrong with the "scalar glob()" idiom you used.
> A bit of googling suggested "grep -e, glob()" instead, and
> that seems to work for me. sifaka seems happy with the
> attached patch.
I'm looking at something else, namely the attached.
Will check your patch out too.
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
Attachments:
[text/x-patch] bfdirfix.patch (868B, ../[email protected]/3-bfdirfix.patch)
download | inline diff:
diff --git a/PGBuild/Utils.pm b/PGBuild/Utils.pm
index b97de92..d96dcec 100644
--- a/PGBuild/Utils.pm
+++ b/PGBuild/Utils.pm
@@ -417,7 +417,7 @@ sub check_install_is_complete
$tmp_loc = "$tmp_loc/$install_dir";
$bindir = "$tmp_loc/bin";
$libdir = "$tmp_loc/lib";
- $libdir .= '/postgresql' unless $libdir =~ /postgres|pgsql/;
+ $libdir .= '/postgresql' unless $install_dir =~ /postgres|pgsql/;
return (-d $bindir && -d $libdir);
}
elsif (-e "$build_dir/src/Makefile.global") # i.e. not msvc
@@ -429,7 +429,7 @@ sub check_install_is_complete
$tmp_loc = "$tmp_loc/$install_dir";
$bindir = "$tmp_loc/bin";
$libdir = "$tmp_loc/lib";
- $libdir .= '/postgresql' unless $libdir =~ /postgres|pgsql/;
+ $libdir .= '/postgresql' unless $install_dir =~ /postgres|pgsql/;
}
# these files should be present if we've temp_installed everything,
view thread (34+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: scalability bottlenecks with (many) partitions (and more)
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox