pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [HACKERS] Cutting initdb's runtime (Perl question embedded)
Date: Wed, 12 Sep 2018 10:00:21 -0400
Message-ID: <949.1536760821@sss.pgh.pa.us> (raw)
In-Reply-To: <20180912073701.GM25160@paquier.xyz>
References: <20180509153924.32kvslqeqdyco7c5@alvherre.pgsql>
	<8873.1525881373@sss.pgh.pa.us>
	<21138.1525969099@sss.pgh.pa.us>
	<25428.1533925885@sss.pgh.pa.us>
	<20180912073701.GM25160@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> One thing that I can see changing with this patch is how timezone is set
> in postgresql.conf.  For example, on HEAD I get 'Japan' while this patch
> gives back 'Asia/Tokyo'.  Could it be an issue for countries with
> multiple timezones?  I am not sure how Russian systems would react on
> that for example.

Interesting --- what platform were you testing on?

I believe that this patch will never make for any functional change,
it will only give you some other alias for the zone it would have
selected anyway.  This could only fail to be true if there are
distinct timezones that score_timezone() is failing to tell apart,
which would be a bug in score_timezone, not this patch.  (Presumably,
we could fix any such bug by increasing the number of dates that
score_timezone tests.)

Since the tzdb database is rather full of aliases, for instance the
one you mentioned

$ grep ^Li src/timezone/data/tzdata.zi
...
Li Asia/Tokyo Japan
...

there is certainly plenty of opportunity for this to change the
apparent value of TimeZone.  But I think it's for the better:
instead of choosing an alias that happens to be first according
to some unspecified search order, it will choose the alias that
somebody actually configured the operating system with.

			regards, tom lane




view thread (52+ messages)  latest in thread

Message-ID: <949.1536760821@sss.pgh.pa.us>
Permalink:  ../949.1536760821@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/949.1536760821@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
  Subject: Re: [HACKERS] Cutting initdb's runtime (Perl question embedded)
  In-Reply-To: <949.1536760821@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox