From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Joe Conway <mail@joeconway.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: Incautious handling of overlength identifiers
Date: Mon, 26 Dec 2016 14:07:30 -0500
Message-ID: <9597.1482779250@sss.pgh.pa.us> (raw)
In-Reply-To: <20161226183647.hjlzi2vqyqvyevsa@alvherre.pgsql>
References: <20161226183647.hjlzi2vqyqvyevsa@alvherre.pgsql>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> I also admit it didn't occur to me to test the function(s) against
> overlength input when developing it. I wouldn't object to adding code
> to deal with overlength identifies, but I'm not really sure I would
> choose truncation over reporting an error. But whatever it'd be, it'd
> be at that level, not at the lower (hash function) level.
Yeah, I'm now convinced that whatever we do about this, if we do anything,
needs to be at a higher code level. It's not hashname()'s job to prevent
use of overlength names. I'll go remove the Assert.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, michael.paquier@gmail.com, mail@joeconway.com
Subject: Re: Incautious handling of overlength identifiers
In-Reply-To: <9597.1482779250@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox