pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Petr Jelinek <petr@2ndquadrant.com>
Subject: Re: Questionable ping logic in LogicalRepApplyLoop
Date: Fri, 04 Sep 2020 17:41:11 -0400
Message-ID: <968097.1599255671@sss.pgh.pa.us> (raw)
In-Reply-To: <20200904204147.GA18660@alvherre.pgsql>
References: <20200904204147.GA18660@alvherre.pgsql>

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> ... oh look!  commit 3f60f690fac1 moved last_recv_timestamp without
> realizing that ping_sent had to get the same treatment.

Hah, I wondered if something like that had happened, but I didn't
get around to excavating in the git history yet.  Thanks for doing so.

Will push a fix later.

			regards, tom lane





view thread (3+ messages)

Message-ID: <968097.1599255671@sss.pgh.pa.us>
Permalink:  ../968097.1599255671@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/968097.1599255671@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, petr@2ndquadrant.com
  Subject: Re: Questionable ping logic in LogicalRepApplyLoop
  In-Reply-To: <968097.1599255671@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox