pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Drouvot, Bertrand <bdrouvot@amazon.com>
Subject: Re: Generating code for query jumbling through gen_node_support.pl
Date: Thu, 26 Jan 2023 09:37:13 +0100
Message-ID: <9695f035-0f2b-92b9-deed-0b7e5bb7e4e0@enterprisedb.com> (raw)
In-Reply-To: <Y8+BdCOjxykre5es@paquier.xyz>
References: <d74d2681-5c07-2f6e-d177-995905015311@enterprisedb.com>
	<Y8YakMwx2a6Y63oR@paquier.xyz>
	<e4801c28-cb5b-3b81-bda1-03af8df1fef9@enterprisedb.com>
	<Y8ZTvD6nEqNttAHJ@paquier.xyz>
	<Y8eZ9/3STyhF57RV@paquier.xyz>
	<50b571dc-e0c0-22be-9803-4a3480d2e792@enterprisedb.com>
	<Y8oaA5Vxnr4rzEDJ@paquier.xyz>
	<e4d61d52-4992-d190-b5ad-48c6c752942c@enterprisedb.com>
	<Y8tdmPlzFyNcrPR3@paquier.xyz>
	<bf604c8d-b6e9-284b-327a-cac8417a74e8@enterprisedb.com>
	<Y8+BdCOjxykre5es@paquier.xyz>

On 24.01.23 07:57, Michael Paquier wrote:
>> For the 0004 patch, it should be documented why one would want one behavior
>> or the other.  That's totally unclear right now.
> I am not 100% sure whether we should have this part at the end, but as
> an exit path in case somebody complains about the extra load with the
> automated jumbling compared to the hash of the query strings, that can
> be used as a backup.  Anyway, attached is what would be a
> clarification.

Ok, the documentation make sense now.  I wonder what the performance 
impact is.  Probably, nobody cares about microoptimizing CREATE TABLE 
statements.  But BEGIN/COMMIT could matter.  However, whatever you do in 
between the BEGIN and COMMIT will already be jumbled, so you're already 
paying the overhead.  Hopefully, jumbling such simple commands will have 
no noticeable overhead.

In other words, we should test this and hopefully get rid of the 
'string' method.





view thread (44+ messages)  latest in thread

Message-ID: <9695f035-0f2b-92b9-deed-0b7e5bb7e4e0@enterprisedb.com>
Permalink:  ../9695f035-0f2b-92b9-deed-0b7e5bb7e4e0@enterprisedb.com/
Also on:    postgresql.org/message-id/9695f035-0f2b-92b9-deed-0b7e5bb7e4e0@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org, bdrouvot@amazon.com
  Subject: Re: Generating code for query jumbling through gen_node_support.pl
  In-Reply-To: <9695f035-0f2b-92b9-deed-0b7e5bb7e4e0@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox