From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: shared memory based stat collector (was: Sharing record typmods between backends)
Date: Mon, 14 Aug 2017 12:16:05 -0400
Message-ID: <9714.1502727365@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+TgmobQVbz4K_+RSmiM9HeRKpy3vS5xnbkL95gSEnWijzprKQ@mail.gmail.com>
References: <20170814005656.d5tvz464qkmz66tq@alap3.anarazel.de>
<32138.1502675970@sss.pgh.pa.us>
<CA+TgmobQVbz4K_+RSmiM9HeRKpy3vS5xnbkL95gSEnWijzprKQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Robert Haas <robertmhaas@gmail.com> writes:
> On Sun, Aug 13, 2017 at 9:59 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> In principle we could keep the existing mechanism as a fallback.
>> Whether that's worth the trouble is debatable. The current code
>> in initdb believes that every platform has some type of DSM support
>> (see choose_dsm_implementation). Nobody's complained about that,
>> and it certainly works on every buildfarm animal. So for all we know,
>> dynamic_shared_memory_type = none is broken already.
> Actually, now that you mention it, I think it *is* broken already, or
> more to the point, if you configure that value, the autovacuum
> launcher hangs up, because of the AutovacuumWorkItem stuff that Alvaro
> added. When I just tested it, the AV launcher somehow ended up
> waiting for AutovacuumLock and I had to SIGQUIT the server to shut it
> down.
Hmm, shouldn't that be an open item for v10?
> ... If somebody has a system where no other form of shared
> memory, works dynamic_shared_memory_type = mmap is still a thing, so
> the use case for "none" seems very thin indeed. I'd vote for just
> ripping it out in v11.
Just FYI, the only values being reported by buildfarm animals are
"posix", "sysv", and "windows". So while mmap may be a thing,
it's an untested thing.
dsm_type | critters_reporting
-----------+--------------------
posix | 69
sysv | 13
windows\r | 10
(3 rows)
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, robertmhaas@gmail.com, alvherre@2ndquadrant.com, andres@anarazel.de, thomas.munro@enterprisedb.com, dilipbalaut@gmail.com
Subject: Re: shared memory based stat collector (was: Sharing record typmods between backends)
In-Reply-To: <9714.1502727365@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox