From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>
To: Magnus Hagander <magnus@hagander.net>
Cc: Oskari Saarenmaa <os@ohmu.fi>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Tobias Oberstein <tobias.oberstein@gmail.com>
Subject: Re: pread() and pwrite()
Date: Thu, 27 Sep 2018 10:03:51 -0400
Message-ID: <983a8d48-64fa-e2f7-55c4-41e20bc51ef5@redhat.com> (raw)
In-Reply-To: <CAEepm=1DZSzdBRDbXFXSiu_Hiv08f22kFmgCi7ZBRERF_=ZCPg@mail.gmail.com>
References: <CAEepm=02rapCpPR3ZGF2vW=SBHSdFYO_bz_f-wwWJonmA3APgw@mail.gmail.com>
<20180720081459.GC22214@saarenmaa.fi>
<CAEepm=2qRXWM+uX26dPn6S=TAqi8FfuAZ9vG8tZW9Jo7w6YeQw@mail.gmail.com>
<7f379440-dfec-70ca-8a0d-942f1381936b@redhat.com>
<c2f56d0a-cadd-3df1-ae48-b84dc8128c37@redhat.com>
<CAEepm=1DZSzdBRDbXFXSiu_Hiv08f22kFmgCi7ZBRERF_=ZCPg@mail.gmail.com>
Hi Thomas,
On 9/18/18 9:48 PM, Thomas Munro wrote:
> It certainly wouldn't hurt... but more pressing to get this committed
> would be Windows support IMHO. I think the thing to do is to open
> files with the FILE_FLAG_OVERLAPPED flag, and then use ReadFile() and
> WriteFile() with an LPOVERLAPPED struct that holds an offset, but I'm
> not sure if I can write that myself. I tried doing some semi-serious
> Windows development for the fsyncgate patch using only AppVeyor CI a
> couple of weeks ago and it was like visiting the dentist.
>
Sorry, no idea about this. Maybe Magnus can provide some feedback ?
> On Thu, Sep 6, 2018 at 6:42 AM Jesper Pedersen
>> Once resolved the patch passes make check-world, and a strace analysis
>> shows the associated read()/write() have been turned into
>> pread64()/pwrite64(). All lseek()'s are SEEK_END's.
>
> Yeah :-)
Thanks for v5 too.
Best regards,
Jesper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jesper.pedersen@redhat.com, thomas.munro@enterprisedb.com, magnus@hagander.net, os@ohmu.fi, tobias.oberstein@gmail.com
Subject: Re: pread() and pwrite()
In-Reply-To: <983a8d48-64fa-e2f7-55c4-41e20bc51ef5@redhat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox