public inbox for [email protected]
help / color / mirror / Atom feedFrom: Tom Lane <[email protected]>
To: Robert Haas <[email protected]>
Cc: David Geier <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: get rid of Pointer type, mostly
Date: Mon, 24 Nov 2025 14:15:13 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmobkziCEOmm+Pc7-fDxuoZY1fFvEPwFz-y5hUf-V-kzhtQ@mail.gmail.com>
References: <[email protected]>
<[email protected]>
<CA+Tgmobo9ZMC0h1Z1Te9whf7q3LN7wUkzFLyuxfMZ4dyTNqKnw@mail.gmail.com>
<[email protected]>
<CA+TgmobhKe5WJybZ0EGQ85Qkxr-KLx4uW2_hFqt0iPbYq-af7Q@mail.gmail.com>
<[email protected]>
<[email protected]>
<CA+TgmobkziCEOmm+Pc7-fDxuoZY1fFvEPwFz-y5hUf-V-kzhtQ@mail.gmail.com>
Robert Haas <[email protected]> writes:
> On Mon, Nov 24, 2025 at 1:46 PM David Geier <[email protected]> wrote:
>> The GIN code makes use of pointer but src/backend/access/gin only has 29
>> occurrences. If you like I can help out fixing up the GIN code and share
>> a page here. Let me know.
> I'd go for it! I mean, who knows whether your patch will be accepted?
> But another pair of eyes couldn't hurt. It seems like we all agree
> that a full removal of Pointer would be better than a partial removal;
> it's just a question of whether we can get there without too much
> other awkwardness.
If there are actually places in GIN where using void* would be less
readable than using Pointer, that would certainly be interesting
information. Perhaps the patch would need to spend some effort
on adding comments, not just mechanically replacing the typedef?
regards, tom lane
view thread (23+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: get rid of Pointer type, mostly
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox