pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Peter Eisentraut <peter_e@gmx.net>
Subject: Re: logical replication launcher crash on buildfarm
Date: Sat, 15 Apr 2017 14:49:42 -0400
Message-ID: <9858.1492282182@sss.pgh.pa.us> (raw)
In-Reply-To: <65ecec21-1272-5c46-3c39-501a2298598e@2ndquadrant.com>
References: <e3c35f3a-426d-b1ca-7fe5-9241c2717013@2ndquadrant.com>
	<CA+Tgmoae_obbYapxDhELe852TO1nFGOdVbWiUwa6Gf+ODxjHnQ@mail.gmail.com>
	<0471e978-b121-ad2f-2879-f1694d9a5ce7@2ndquadrant.com>
	<d217ee26-f3d1-4079-0110-3f7ee44ad6b4@2ndquadrant.com>
	<2124fb62-2393-8525-4fe9-b95b1b689d09@2ndquadrant.com>
	<CA+TgmobNi6++NFCQgSay4A05-FNVFfYVKxfBa00zke8vqU1V3Q@mail.gmail.com>
	<09d8ad33-4287-a09b-a77f-77f8761adb5e@2ndquadrant.com>
	<CA+TgmoZktru0SK1b9888gYF=zmX_haRm+6i8rBP0APS6yO8+NA@mail.gmail.com>
	<8ebd3aa3-55eb-1106-7c10-7e7579f94582@2ndquadrant.com>
	<CA+TgmobGk3DEo++oqkFi8AaYXhCs-0DUNMU9HdCh56udXFF=PA@mail.gmail.com>
	<20170401021928.47zjjryhty5kdzqz@alap3.anarazel.de>
	<548f9c1d-eafa-e3fa-9da8-f0cc2f654e60@2ndquadrant.com>
	<5615.1492228914@sss.pgh.pa.us>
	<65ecec21-1272-5c46-3c39-501a2298598e@2ndquadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Petr Jelinek <petr.jelinek@2ndquadrant.com> writes:
> On 15/04/17 06:01, Tom Lane wrote:
>> I've had more than enough of seeing buildfarm failures from culicidae,
>> so I whacked this around until I was happy with it and pushed it.
>> Further adjustments welcome of course.

> Thanks. Seems like culicidae is finally happy with master.

Well, only sort of happy, but I see how we can fix that.

>> I don't really understand why 9.6 needs a significantly different
>> patch.  AFAICS, it simply does not work (with any reliability)
>> for a loadable module to call CreateParallelContext directly in 9.6.

> I think the problem is that if somebody was using CreateParallelContext
> it may have worked on unix when just normally forking if the extension
> was loaded via shared_preload_libraries. And lot of extensions are linux
> only. So we might break working setup for somebody if we change the
> function signature.

Ah, I didn't think of shared_preload_libraries.  OK, we can't change
the signature in released branches.

> We may need to keep CreateParallelContext as is in back branches and add
> some CreateParallelContextInternal which would do what
> CreateParallelContext does in master (and is used by postgres) and then
> make CreateParallelContextForExternalFunction simple wrapper around
> that. It's somewhat ugly though.

Yeah, but ugly compatibility hacks in back branches are pretty common.
But rather than inventing "CreateParallelContextInternal", I suggest
we just have the core code call CreateParallelContextForExternalFunction.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (41+ messages)  latest in thread

Message-ID: <9858.1492282182@sss.pgh.pa.us>
Permalink:  ../9858.1492282182@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/9858.1492282182@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, petr.jelinek@2ndquadrant.com, andres@anarazel.de, robertmhaas@gmail.com, peter_e@gmx.net
  Subject: Re: logical replication launcher crash on buildfarm
  In-Reply-To: <9858.1492282182@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox