From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Lakhin <exclusion@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: More time spending with "delete pending"
Date: Wed, 18 Nov 2020 13:53:17 -0500
Message-ID: <995713.1605725597@sss.pgh.pa.us> (raw)
In-Reply-To: <979f4ee6-9960-e37f-f3ee-f458e87777b0@gmail.com>
References: <c3427edf-d7c0-ff57-90f6-b5de3bb62709@gmail.com>
<20201115011112.GW30691@telsasoft.com>
<979f4ee6-9960-e37f-f3ee-f458e87777b0@gmail.com>
Alexander Lakhin <exclusion@gmail.com> writes:
> 15.11.2020 04:11, Justin Pryzby wrote:
>> Your patch introduces a "loops", but doesn't use it to escape the loop.
> Indeed, this is my mistake. Please look at the corrected patch (now that
> code corresponds to the pgwin32_open() as intended).
So what you're saying (and what the buildfarm seems to confirm, since
we are still seeing "Permission denied" failures from time to time,
eg [1]) is that all that code that bed90759f added to deal with
delete-pending is just junk, because we never get that far if the
file is delete-pending. So shouldn't we remove all of it? (That's
lines 214-276 in win32stat.c, plus some earlier declarations that
would now be unneeded.)
I'd be kind of inclined to change pgwin32_open() to use
microsoft_native_stat, as well, because these two functions
really ought to be handling this exactly alike.
regards, tom lane
[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=fairywren&dt=2020-11-18%2018%3A02%3A04
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, exclusion@gmail.com, pryzby@telsasoft.com
Subject: Re: More time spending with "delete pending"
In-Reply-To: <995713.1605725597@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox