public inbox for [email protected]
help / color / mirror / Atom feedFrom: Jacob Champion <[email protected]>
To: Jelte Fennema <[email protected]>
To: Tom Lane <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: Add non-blocking version of PQcancel
Date: Fri, 4 Nov 2022 08:58:34 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <DBBPR83MB0507788F756288750A6327F8F7469@DBBPR83MB0507.EURPRD83.prod.outlook.com>
References: <[email protected]>
<CA+Tgmoav-v8HVuA-kLJM3Kf6XHtVfOPajQtyAkb5ejs7C_Aw2A@mail.gmail.com>
<[email protected]>
<CA+TgmoZUb5yEFNi7pLpoqoOxfwyrCYfczjxeqYor21Cy+Ozasg@mail.gmail.com>
<[email protected]>
<HE1PR8303MB00732AF8BEF2E45DACFE6633F71D9@HE1PR8303MB0073.EURPRD83.prod.outlook.com>
<HE1PR8303MB00735DC38F45BD63A3A49347F71F9@HE1PR8303MB0073.EURPRD83.prod.outlook.com>
<[email protected]>
<HE1PR8303MB00732A831BE871DF360A293CF7E09@HE1PR8303MB0073.EURPRD83.prod.outlook.com>
<AM5PR83MB037283BB5E7BE0EEE0016E6BF7E59@AM5PR83MB0372.EURPRD83.prod.outlook.com>
<[email protected]>
<PR3PR83MB04765D30B272D65DE9E42CF1F7B99@PR3PR83MB0476.EURPRD83.prod.outlook.com>
<[email protected]>
<DBBPR83MB0507788F756288750A6327F8F7469@DBBPR83MB0507.EURPRD83.prod.outlook.com>
On 10/5/22 06:23, Jelte Fennema wrote:
> In my first version of this patch, this is exactly what I did. But then
> I got this feedback from Jacob, so I changed it to reusing PGconn:
>
>> [snip]
>
> I changed it back to use PGcancelConn as per your suggestion and I
> agree that the API got better because of it.
Sorry for the whiplash!
Is the latest attachment the correct version? I don't see any difference
between the latest 0001 and the previous version's 0002 -- it has no
references to PG_TEST_TIMEOUT_DEFAULT, PGcancelConn, etc.
Thanks,
--Jacob
view thread (34+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add non-blocking version of PQcancel
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox