From: Mark Dilger <mark.dilger@enterprisedb.com>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: REINDEX backend filtering
Date: Mon, 15 Mar 2021 10:40:25 -0700
Message-ID: <9AC710C9-7006-43EC-93F6-7A7ABFE09E80@enterprisedb.com> (raw)
In-Reply-To: <20210315173401.yqgxgmbspiyfrbks@nol>
References: <20210303055659.wowfwt2nyxuynzqg@nol>
<20210314081007.kr3q5qusyhl2i4p4@nol>
<YE35Y//jLIb7gFLu@paquier.xyz>
<20210314145737.enqhi2jxszws3ywi@nol>
<YE6ikDiXyA0w19UI@paquier.xyz>
<20210315003551.enuwfghdh7qhfnb2@nol>
<20210315033320.4273frstqn7w6kh7@nol>
<0E0B73C0-EBC0-490A-9347-66A66E3338AE@enterprisedb.com>
<20210315165213.tgxwtjtnlnr2q3f5@nol>
<074D5DFD-4D47-4A84-93A5-C2DC8935E6E9@enterprisedb.com>
<20210315173401.yqgxgmbspiyfrbks@nol>
> On Mar 15, 2021, at 10:34 AM, Julien Rouhaud <rjuju123@gmail.com> wrote:
>
> On Mon, Mar 15, 2021 at 10:13:55AM -0700, Mark Dilger wrote:
>>
>>
>>> On Mar 15, 2021, at 9:52 AM, Julien Rouhaud <rjuju123@gmail.com> wrote:
>>>
>>> But there are also the tests in collate.icu.utf8.out which will fake outdated
>>> collations (that's the original tests for the collation tracking patches) and
>>> then check that outdated indexes are reindexed with both REINDEX and REINDEX
>>> (OUDATED).
>>>
>>> So I think that all cases are covered. Do you want to have more test cases?
>>
>> I thought that just checked cases where a bogus 'not a version' was put into pg_catalog.pg_depend. I'm talking about having a collation provider who returns a different version string and has genuinely different collation rules between versions, thereby breaking the index until it is updated. Is that being tested?
>
> No, we're only checking that the infrastructure works as intended.
>
> Are you saying that you want to implement a simplistic collation provider with
> "tunable" ordering, so that you can actually check that an ordering change will
> be detected as a corrupted index, as in you'll get some error or incorrect
> results?
I'm saying that your patch seems to call down to get_collation_actual_version() via get_collation_version_for_oid() from your new function do_check_index_has_outdated_collation(), but I'm not seeing how that gets exercised.
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: mark.dilger@enterprisedb.com, rjuju123@gmail.com, michael@paquier.xyz, magnus@hagander.net, pgsql-hackers@lists.postgresql.org
Subject: Re: REINDEX backend filtering
In-Reply-To: <9AC710C9-7006-43EC-93F6-7A7ABFE09E80@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox