public inbox for [email protected]  

help / color / mirror / Atom feed

From: Burd, Greg <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [PATCH] Add tests for Bitmapset
Date: Mon, 8 Sep 2025 14:21:28 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <aLsvPdSHJdRCEk7v@nathan>
References: <[email protected]>
	<aLpENihhKL4vOxeX@nathan>
	<[email protected]>
	<aLsvPdSHJdRCEk7v@nathan>


> On Sep 5, 2025, at 2:43 PM, Nathan Bossart <[email protected]> wrote:
> 
> On Fri, Sep 05, 2025 at 10:48:21AM -0400, Burd, Greg wrote:
>> I looked at both radix tree and binary heap and how they use random sets when
>> testing.  Binary heap uses it to create different random sets of numbers to
>> use across multiple tests while radix tree has a single function that focuses
>> on randomized data.  I decided not to add randomization into the tests of
>> Bitmapset simply because I like avoiding non-deterministic behavior.  But in
>> tests I guess that can be helpful finding future unknown corner cases.  I'm
>> on the fence as to the value, your call.  :)
> 
> I'm not too concerned about it.  We've lived without a dedicated test suite
> for Bitmapset for a very long time, so any amount of test coverage is an
> improvement.  Like you said, adding some randomization might be helpful for
> finding weird bugs we wouldn't have thought to test.  And, given the many,
> many machines that run the tests, IMHO it'd only help build even more
> confidence in the code.  If my suggestion inspires you to update the patch,
> great, but I'm fine with proceeding with what you already wrote, too.

Nathan, thanks for considering the patch.  Honestly, I'm fine with it as is.
We can revisit later if needed.  This does what I'd intended, test and document
in code the API and implementation making future changes to that more
transparent.

Thanks!

-greg

-- 
> nathan

view thread (81+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Add tests for Bitmapset
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox