public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nathan Bossart <[email protected]>
To: Greg Burd <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [PATCH] Add tests for Bitmapset
Date: Thu, 4 Sep 2025 21:00:22 -0500
Message-ID: <aLpENihhKL4vOxeX@nathan> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On Fri, Aug 15, 2025 at 11:39:23AM -0400, Greg Burd wrote:
> I noticed that there are no tests for Bitmapset in src/test/modules as
> is the case for other similar things like radixtree, rbtree, etc. so I
> created one.  I realize that Bitmapset is already "tested" by all the
> other code that uses it, but I was able to find one minor oversight[1]
> in that code with these new tests.
> 
> I hope I've covered all the bases, but if you have thoughts on other
> ways to test Bitmapset I'll happily add them to the patch.

Adding some tests here seems like a good idea.  I might look into some ways
to trim it down a bit, but that'd just be minor editorialization.  One
other thing to consider is adding randomness to the tests (see
test_radixtree and test_binaryheap for examples).

-- 
nathan

view thread (81+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Add tests for Bitmapset
  In-Reply-To: <aLpENihhKL4vOxeX@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox