From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: vignesh C <vignesh21@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Remove unused function argument
Date: Wed, 6 Nov 2019 08:20:20 +0100
Message-ID: <9b3baff2-779f-c4ef-693b-5d4029d2ff0c@2ndquadrant.com> (raw)
In-Reply-To: <CALDaNm0O_OwOn7_mRcEw8UCoQ0ssoq2=00-=OMoUWeT+qb1FDg@mail.gmail.com>
References: <ec8a8b45-a30b-9193-cd4b-985d60d1497e@2ndquadrant.com>
<CALDaNm0O_OwOn7_mRcEw8UCoQ0ssoq2=00-=OMoUWeT+qb1FDg@mail.gmail.com>
On 2019-10-30 06:51, vignesh C wrote:
> On Tue, Oct 29, 2019 at 2:51 PM Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>>
>> The cache_plan argument to ri_PlanCheck has not been used since
>> e8c9fd5fdf768323911f7088e8287f63b513c3c6. I propose to remove it.
>>
>> That commit said "I left it alone in case there is any future need for
>> it" but there hasn't been a need in 7 years, and I find it confusing to
>> have an unused function argument without a clear purpose. It would
>> trivial to put it back if needed.
>>
> Code changes looks fine to me.
pushed, thanks
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, vignesh21@gmail.com
Subject: Re: Remove unused function argument
In-Reply-To: <9b3baff2-779f-c4ef-693b-5d4029d2ff0c@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox