From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pageinspect: Hash index support
Date: Wed, 21 Sep 2016 08:27:06 -0400
Message-ID: <9c46ef79-218f-38f2-d785-fe4630141801@redhat.com> (raw)
In-Reply-To: <CAB7nPqRKhWd9OrBh3iq1uoA6Hxkf=GwG27jAuki-F0RHWRSjig@mail.gmail.com>
References: <e2ac6c58-b93f-9dd9-f4e6-d6d30add7fdf@redhat.com>
<20160830170633.GA508711@alvherre.pgsql>
<CAMkU=1wghadVOxkphJTQUqukgNkE7ETPci0g55Y+fqXO4Q43PQ@mail.gmail.com>
<0f99b6b0-0e54-0f6e-9502-f8cb6f194c17@redhat.com>
<CAB7nPqSLVbe-wXCd77CMx6vHKfRd6thUwv7nzP54Lv9k4Q6hww@mail.gmail.com>
<3493caf5-6d50-8915-7612-bd830972f513@redhat.com>
<CAMkU=1weMVE+Re7NQyAtXT5g6E5Fziw9PVU9UDapb0AG5MH=YQ@mail.gmail.com>
<bee4df6a-79d2-f04e-7f2c-c31581c25a45@redhat.com>
<CAB7nPqRKhWd9OrBh3iq1uoA6Hxkf=GwG27jAuki-F0RHWRSjig@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 09/21/2016 02:14 AM, Michael Paquier wrote:
>> Adjusted in v4.
>
> Thanks for the new version.
>
>> Code/doc will need an update once the CHI patch goes in.
>
> If you are referring to the WAL support, I guess that this patch or
> the other patch could just rebase and adjust as needed.
>
It is the main patch [1] that defines the new constants for page type.
But I'll submit an update for pageinspect when needed.
> hash_page_items and hash_page_stats share a lot of common points with
> their btree equivalents, still doing a refactoring would just impact
> the visibility of the code, and it is wanted as educational in this
> module, so let's go with things the way you suggest.
>
Ok.
> + <para>
> + The type information will be '<literal>m</literal>' for a metadata page,
> + '<literal>v</literal>' for an overflow page,
> '<literal>b</literal>' for a bucket page,
> + '<literal>i</literal>' for a bitmap page, and
> '<literal>u</literal>' for an unused page.
> + </para>
> Other functions don't go into this level of details, so I would just
> rip out this paragraph.
>
I'll add an annotation for this part, and leave it for the committer to
decide, since Jeff wanted documentation for the 'type' information.
> The patch looks in pretty good shape to me, so I am switching it as
> ready for committer.
>
Thanks for your feedback !
Best regards,
Jesper
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jesper.pedersen@redhat.com, michael.paquier@gmail.com, jeff.janes@gmail.com, alvherre@2ndquadrant.com
Subject: Re: pageinspect: Hash index support
In-Reply-To: <9c46ef79-218f-38f2-d785-fe4630141801@redhat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox