From: Jacob Champion <pchampion@vmware.com>
To: tgl@sss.pgh.pa.us <tgl@sss.pgh.pa.us>
Cc: daniel@yesql.se <daniel@yesql.se>
Cc: peter.eisentraut@enterprisedb.com <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: michael@paquier.xyz <michael@paquier.xyz>
Subject: Re: Preventing abort() and exit() calls in libpq
Date: Wed, 30 Jun 2021 22:58:22 +0000
Message-ID: <9e32c5120efa37cca606351e4516052107c821bf.camel@vmware.com> (raw)
In-Reply-To: <632283.1625093816@sss.pgh.pa.us>
References: <3128896.1624742969@sss.pgh.pa.us>
<18eda75d-af6d-3fc0-03b6-607eff9f392a@enterprisedb.com>
<622907.1625084114@sss.pgh.pa.us>
<630837.1625092151@sss.pgh.pa.us>
<67ddcb26f82acaffb26c59b7d8e4cd75399b2cd3.camel@vmware.com>
<632283.1625093816@sss.pgh.pa.us>
On Wed, 2021-06-30 at 18:56 -0400, Tom Lane wrote:
> Jacob Champion <pchampion@vmware.com> writes:
> > On Wed, 2021-06-30 at 18:29 -0400, Tom Lane wrote:
> > > Looks like we'd have to make use of a dummy stamp-file, more or less
> > > as attached. Any objections?
> > Spitballing -- if you don't like the stamp file, you could add the
> > check to the end of the $(shlib) rule, surrounded by an ifeq check.
> > Then .DELETE_ON_ERROR should take care of the rest, I think.
>
> Hmm ... I'd been thinking we don't use .DELETE_ON_ERROR, but on
> second look we do, so that could be a plausible approach.
>
> On balance though, the separate rule seems better, because
> .DELETE_ON_ERROR would destroy the evidence about why "nm"
> failed, which could be annoying when investigating problems.
Good point. +1 to the stamp approach, then.
--Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pchampion@vmware.com, tgl@sss.pgh.pa.us, daniel@yesql.se, peter.eisentraut@enterprisedb.com, michael@paquier.xyz
Subject: Re: Preventing abort() and exit() calls in libpq
In-Reply-To: <9e32c5120efa37cca606351e4516052107c821bf.camel@vmware.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox