public inbox for [email protected]
help / color / mirror / Atom feedFrom: Andrey Borodin <[email protected]>
To: Kirill Reshke <[email protected]>
Cc: Melanie Plageman <[email protected]>
Cc: Alexander Lakhin <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: Chao Li <[email protected]>
Cc: Xuneng Zhou <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Subject: Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)
Date: Fri, 30 Jan 2026 16:09:34 +0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALdSSPjnnXyJ3Ma6VTfYOT2KvOf_f6poMrPtAjNc5V2iFSE8Vw@mail.gmail.com>
References: <CABPTF7X1X810eT7hjRz9M69sjMv1Vui5gXQEGhqYXmkmywhHCQ@mail.gmail.com>
<CAAKRu_ZcK+ez71W7j+QzMo0gSafTsbGA3TU-fVSptw7yh41BEQ@mail.gmail.com>
<[email protected]>
<CAAKRu_ZCjHoRPfQ8AbMrFY8TOMCPAvZ0_m9SX7yg0edfTk45-g@mail.gmail.com>
<[email protected]>
<CAAKRu_a04jbDACwzRYwzDND31aPyf7Yvz9TAZrTr=+F5bK1aVA@mail.gmail.com>
<CALdSSPjcv25jmXm29X-MRWZBae6+HwcWfVH1PE8NfD=EMTnkAg@mail.gmail.com>
<CAAKRu_bwtBEzDwemyim1r6yYonw7FTyFr1HXG8vywCe-MdbPBQ@mail.gmail.com>
<[email protected]>
<CAAKRu_YQd=2KvomM+RHcpeDKj0bq+peJ=3W-fip+pkvzA-Jq9w@mail.gmail.com>
<7ib3sa55sapwjlaz4sijbiq7iezna27kjvvvar4dpgkmadml6t@gfpkkwmdnepx>
<CAAKRu_bs+gZ83QDacmBxunPvCGnXJ05hxP2BDPJ3BGwdbGRXzg@mail.gmail.com>
<[email protected]>
<CALdSSPjUUfdb5tL0hdH9m3PzRePDSFDBV-jfAj6BdzGE-8SBtw@mail.gmail.com>
<CAAKRu_ZnJiLaQD_pcTN=KGPHt3m-XirR+=Jj3OqURghPmu01yg@mail.gmail.com>
<CALdSSPhFrQ4=N6yJ0N4pQ=RKjeSfU7N3wz7xpLTwsUjLc-6Tdg@mail.gmail.com>
<CALdSSPjnnXyJ3Ma6VTfYOT2KvOf_f6poMrPtAjNc5V2iFSE8Vw@mail.gmail.com>
Well, converting to TAP seems feasible to me. This will make test more stable.
> On 30 Jan 2026, at 14:59, Kirill Reshke <[email protected]> wrote:
>
> I use 'autovacuum-worker-start' injection point to 'disable'
> autovacuum until test is done
If you just set autovacuum off - the test will be executed on bf animals that has no injection points.
Also
x4mmm@x4mmm-osx postgres % git am ~/Downloads/v1-0001-Reimplement-regression-tests-from-21796c267-as-TA.patch
Applying: Reimplement regression tests from 21796c267 as TAP-test.
.git/rebase-apply/patch:148: trailing whitespace.
# Check that vacuum phase I does not need to modify the heap buffer. warning: 1 line adds whitespace errors.
There are some typos: "flakky", "introduces", "actuvity", "actaully", "hilding".
Test descriptions are off: you used 'page_header returned as expected' when it's actually about pg_visibility_map_summary.
And, of course, total lack of comments is not good.
However, in principle approach seems good to me.
(FWIW I'm looking into patches 0003-0005 of v33, I'll post when I'll find some nits)
Best regards, Andrey Borodin.
view thread (17+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access)
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox