From: Yuhang Qiu <iamqyh@gmail.com>
To: Nazir Bilal Yavuz <byavuz81@gmail.com>
Cc: Nitin Jadhav <nitinjadhavpostgres@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Andres Freund <andres@anarazel.de>
Subject: Re: aio: Async fsyncs for crash recovery and checkpointer
Date: Tue, 22 Sep 2026 12:03:17 +0800
Message-ID: <C24C12AB-DE89-4EC8-AF08-6157CDA9A8CA@gmail.com> (raw)
In-Reply-To: <CAN55FZ2WnU9pMtjKP-=V+41gzPABuY6hXB_xO3CnOuMvhTVJvg@mail.gmail.com>
References: <CAN55FZ0vLWJQNB=HuHXG2wabFjXJd6OWTa3=kRzwObdZD9poHQ@mail.gmail.com>
<CAMm1aWZQy3U8TDTDP5rOhRE5EmYLtVzCFLqBu7s+roE0bi6TxQ@mail.gmail.com>
<CAN55FZ1wTRvSCnzVH240zb8jEvjSgkc-cOGqMFehGrsQOyK1tA@mail.gmail.com>
<D707392D-96FF-4867-943D-564DAD6644B3@gmail.com>
<CAN55FZ2WnU9pMtjKP-=V+41gzPABuY6hXB_xO3CnOuMvhTVJvg@mail.gmail.com>
Hi Nazir,
Thanks for the comparison. The main benefit of this patch series seems
to be in checkpointing rather than crash recovery, so I think further
testing should focus on that.
> For now, ordinary reopen failures for both relation and SLRU fsyncs
> return -errno.
>
> Done. Relation fsync requests now use io_max_concurrency as their
> limit.
These two changes LGTM.
> However, I think increasing the number of worker processes
> should solve this problem.
Increasing the worker count may help with worker availability, but it
doesn't address contention for storage bandwidth.
One more point: when a worker calls pg_fsync() or pg_fdatasync(), it checks
its own enableFsync. If the issuer has reloaded fsync=on but the worker
still has the old off value, the worker can skip the sync and report
success. Should the issuer's setting or the worker's determine whether
the sync is performed?
Best regards,
Yuhang Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: iamqyh@gmail.com, byavuz81@gmail.com, nitinjadhavpostgres@gmail.com, andres@anarazel.de
Subject: Re: aio: Async fsyncs for crash recovery and checkpointer
In-Reply-To: <C24C12AB-DE89-4EC8-AF08-6157CDA9A8CA@gmail.com>
References: <CAN55FZ0vLWJQNB=HuHXG2wabFjXJd6OWTa3=kRzwObdZD9poHQ@mail.gmail.com> <CAMm1aWZQy3U8TDTDP5rOhRE5EmYLtVzCFLqBu7s+roE0bi6TxQ@mail.gmail.com> <CAN55FZ1wTRvSCnzVH240zb8jEvjSgkc-cOGqMFehGrsQOyK1tA@mail.gmail.com> <D707392D-96FF-4867-943D-564DAD6644B3@gmail.com> <CAN55FZ2WnU9pMtjKP-=V+41gzPABuY6hXB_xO3CnOuMvhTVJvg@mail.gmail.com> <C24C12AB-DE89-4EC8-AF08-6157CDA9A8CA@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox