public inbox for [email protected]  

help / color / mirror / Atom feed
From: Lakshmi N <[email protected]>
To: Amit Langote <[email protected]>
Cc: Hu Xunqi <[email protected]>
Cc: Euler Taveira <[email protected]>
Cc: [email protected] <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Subject: Re: Reject invalid databases in pg_get_database_ddl()
Date: Thu, 16 Apr 2026 21:20:52 -0700
Message-ID: <CA+3i_M_JzLyF14Uf8pbev8pZB6wOWjWnp1QerUz2REDr0PJrxQ@mail.gmail.com> (raw)
In-Reply-To: <CA+HiwqGf_eQNK_bqJzL7YZvXKhpCWsbxxa6pwYVAhQLcPS0rAQ@mail.gmail.com>
References: <CA+3i_M8m1k2gFch+tU0JmAQh9FRV+pFrfTXDrJo+BqmwsTmOhg@mail.gmail.com>
	<CA+HiwqH+0rgMNQDog0AT9dVt0CGjXza_Li80njDhynWqzUwvZw@mail.gmail.com>
	<CA+3i_M8Mq7fr6mUspSa2rLik9+oY4sOeD1qsB_-dvnUB4NrYbg@mail.gmail.com>
	<CA+HiwqFW7uY3Jknf8VzjWoXa1bf0-U6-+JgM+o1ggJ+onyOHHA@mail.gmail.com>
	<[email protected]>
	<CA+HiwqFenEgD4W1QWnHM0whbzWYH=uS6qQzxvKNH7z503HWvxw@mail.gmail.com>
	<CAE4_qQacVuwviLN3qKMUp20e5B11hJ5rc5qUCLmHENixO1xWhQ@mail.gmail.com>
	<CA+HiwqGf_eQNK_bqJzL7YZvXKhpCWsbxxa6pwYVAhQLcPS0rAQ@mail.gmail.com>

Hi,

On Thu, Apr 16, 2026 at 8:31 PM Amit Langote <[email protected]>
wrote:

> Hi,
>
> On Fri, Apr 17, 2026 at 11:49 AM Hu Xunqi <[email protected]> wrote:
> > On Fri, Apr 17, 2026 at 10:16 AM Amit Langote <[email protected]>
> wrote:
> > +       /*
> > +        * Reject invalid databases: datconnlimit = -2 would be emitted
> as
> > +        * CONNECTION LIMIT = -2, which cannot be executed.
> > +        */
> >
> > This comment looks a bit too centered on datconnlimit=-2, but the real
> issue is that an invalid pg_database row should not be deparsed into DDL.
> So, maybe rephrase like:
> >
> > /*
> > * Reject invalid databases. Deparsing a pg_database row in invalid state
> > * can produce SQL that is not executable, such as CONNECTION LIMIT = -2.
> > */
>
> I was trying to be precise about datconnlimit = -2 being the thing
> that produces invalid SQL. But your version covers that with the "such
> as CONNECTION LIMIT = -2" example, and it's closer to the original,
> which was on the right track, just needed to be more precise. Let's go
> with it.
>

This looks good to me. Thank you for reviewing and making the changes!

Regards,
Lakshmi


view thread (13+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Reject invalid databases in pg_get_database_ddl()
  In-Reply-To: <CA+3i_M_JzLyF14Uf8pbev8pZB6wOWjWnp1QerUz2REDr0PJrxQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox