public inbox for [email protected]  
help / color / mirror / Atom feed
From: Robert Haas <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Ryohei Takahashi (Fujitsu) <[email protected]>
Cc: Dave Page <[email protected]>
Cc: Gurjeet Singh <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: doc: pgevent.dll location
Date: Tue, 12 Nov 2024 12:27:37 -0500
Message-ID: <CA+TgmoY9f+rapcAGHMeFvXhG6S9j9rmRvxsTiMCk5g=dFXuTdw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <TY3PR01MB118912125614599641CA881B782522@TY3PR01MB11891.jpnprd01.prod.outlook.com>
	<CABwTF4WczBfnRcqPpF+bfGbBXnv69TtauScokDSRYUvEHSSKDw@mail.gmail.com>
	<CA+Tgmoa_kC1T5PR0C7K0cGo1OEPx2c4zQ13ziwqm=pz7K_367g@mail.gmail.com>
	<CA+OCxoywke+6M7yO7-eUD4RwJiuGk-ydCJqh3bkbG3PjoLAhWg@mail.gmail.com>
	<TY3PR01MB118914759E215A415D418B42B82532@TY3PR01MB11891.jpnprd01.prod.outlook.com>
	<[email protected]>
	<CA+TgmoZ+yTDsL7-u62O1F=YXag8WXqBNDdxy22kfJq_avyKEtg@mail.gmail.com>
	<[email protected]>

On Tue, Nov 12, 2024 at 11:52 AM Peter Eisentraut <[email protected]> wrote:
> So the most straightforward way to "make it work like it used to" would
> be to change src/bin/pgevent/meson.build to use shared_module() instead
> of shared_library().
>
> Based on the explanation in the documentation, this file is really more
> of a plugin and less a shared library, so I think that approach would be
> more correct than not.

I don't understand what the difference is between a shared module and
a shared library, so I find it odd that meson treats them differently.
However, if the consensus is that moving it back to lib is better than
updating the documentation, that's fine with me.

-- 
Robert Haas
EDB: http://www.enterprisedb.com






view thread (17+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: doc: pgevent.dll location
  In-Reply-To: <CA+TgmoY9f+rapcAGHMeFvXhG6S9j9rmRvxsTiMCk5g=dFXuTdw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox