public inbox for [email protected]  

help / color / mirror / Atom feed

From: Robert Haas <[email protected]>
To: Thom Brown <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Dilip Kumar <[email protected]>
Cc: Amul Sul <[email protected]>
Cc: Matthias van de Meent <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: generalized conveyor belt storage
Date: Wed, 20 Apr 2022 10:08:36 -0400
Message-ID: <CA+TgmoZ60zRd1DD19J_n48dKPy-4KvTopcQurwXjoG1AAVS6Vg@mail.gmail.com> (raw)
In-Reply-To: <CAA-aLv4993dAV_B5qwQW8QNbpVXHNHH8S8pdSXnhkr_j0M-THA@mail.gmail.com>
References: <CAFiTN-sQUddO9JPiH3tz+vbNqRqi_pgndecy8k2yXAnO3ymqZA@mail.gmail.com>
	<[email protected]>
	<CAA-aLv4993dAV_B5qwQW8QNbpVXHNHH8S8pdSXnhkr_j0M-THA@mail.gmail.com>

On Wed, Apr 20, 2022 at 8:32 AM Thom Brown <[email protected]> wrote:
> On Wed, 20 Apr 2022 at 13:02, Alvaro Herrera <[email protected]> wrote:
> > What's with the free text in cbstorage.h?  I would guess that this
> > wouldn't even compile, and nobody has noticed because the file is not
> > included by anything yet ...
>
> I'm not able to compile:

Since I haven't been working on this for a while, the patch set's not updated.

> cbfsmpage.c: In function ‘cb_fsmpage_initialize’:
> cbfsmpage.c:34:11: warning: unused variable ‘fsm_block_spacing’
> [-Wunused-variable]
>   unsigned fsm_block_spacing = cb_fsm_block_spacing(pages_per_segment);
>            ^

Hmm, well I guess if that variable is unused we can just delete it.

> cbxlog.c: In function ‘cb_xlog_allocate_payload_segment’:
> cbxlog.c:70:24: error: void value not ignored as it ought to be
>   bool  have_fsm_page = XLogRecGetBlockTag(record, 1, NULL, NULL, NULL);

This is because Tom recently made that function return void instead of
bool. I guess all these will need to be changed to use
XLogRecGetBlockTagExtended and pass an extra NULL for the
*prefetch_buffer argument.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: generalized conveyor belt storage
  In-Reply-To: <CA+TgmoZ60zRd1DD19J_n48dKPy-4KvTopcQurwXjoG1AAVS6Vg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox