pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Robert Haas <robertmhaas@gmail.com>
To: Amul Sul <sulamul@gmail.com>
Cc: Jaime Casanova <jcasanov@systemguards.com.ec>
Cc: Rushabh Lathia <rushabh.lathia@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Ibrar Ahmed <ibrar.ahmad@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Prabhat Sahu <prabhat.sahu@enterprisedb.com>
Subject: Re: [Patch] ALTER SYSTEM READ ONLY
Date: Mon, 25 Oct 2021 10:45:21 -0400
Message-ID: <CA+TgmoZrtgZCTA++wOS+=nXGPhrp6965EZorpRfyvyEpFfdWiQ@mail.gmail.com> (raw)
In-Reply-To: <CAAJ_b97fysj6sRSQEfOHj-y8Jfd5uPqOgO74qast89B4WfD+TA@mail.gmail.com>
References: <CAAJ_b97vxaTA-GZK4AyCJvrpzUsAhGLugXaYrE7mybb4FmOarw@mail.gmail.com>
	<CA+TgmoaPDkcNViu+jtgicBQ2WbHt5J_1P98Zq_00RUwDP5rwiQ@mail.gmail.com>
	<CA+TgmoYaMXTFV02rb-jyPshwAQV=5GLKX02-u-g6L+sJttXxVQ@mail.gmail.com>
	<CAAJ_b96G-oBxDC3C7Y72ER09bsheGHOxBK1HXHVOyHNXjTDmcA@mail.gmail.com>
	<CA+TgmoaScsuDcTYa_-pkBnVP5Xcb_vx0BX2qn6grnTt=+mmH6g@mail.gmail.com>
	<CAAJ_b96KcmmJw6rTEX_br485VYL1MAv89pJ31znctN8e6ri_cQ@mail.gmail.com>
	<CAAJ_b94WUtC2MU5EnDmx-Mhuw1xoN5xyHABbjJzoStP6DHsp9g@mail.gmail.com>
	<CA+Tgmob8zNB_pMr9X6=5syYYeAc9hUtZmZGRLOzW=Oyud3ho0A@mail.gmail.com>
	<CAGPqQf2n0aeeKMv+mA0zpgkqkamEVMCZE_VL74hxCe9hSNOQNg@mail.gmail.com>
	<CAAJ_b9549-u2qo4hgGcE94vcv6sTHUO_Eq+5vB1_-Av5QokJLw@mail.gmail.com>
	<20211007002651.GA20716@ahch-to>
	<CAAJ_b952yF_qZL0s1_dpr9HL0MVt1xp9J02px23aThLKrR7KPg@mail.gmail.com>
	<CAAJ_b97abMuq=470Wahun=aS1PHTSbStHtrjjPaD-C0YQ1AqVw@mail.gmail.com>
	<CA+TgmobppXiL598ytRivAX6-MoRxDxNV4np1h+ybbJdxf2uxgw@mail.gmail.com>
	<CAAJ_b94KNpGXzeEuSHTvrMzkRP0Vp-uveTG604GS_up+paPfbQ@mail.gmail.com>
	<CA+TgmoZ5A26C6OxKApafyuy_sx0VG6VXdD_Q6aSEzsvrPHDwzw@mail.gmail.com>
	<CAAJ_b97fysj6sRSQEfOHj-y8Jfd5uPqOgO74qast89B4WfD+TA@mail.gmail.com>

On Mon, Oct 25, 2021 at 3:05 AM Amul Sul <sulamul@gmail.com> wrote:
> Ok, did the same in the attached 0001 patch.
>
> There is no harm in calling LocalSetXLogInsertAllowed() calling
> multiple times, but the problem I can see is that with this patch user
> is allowed to call LocalSetXLogInsertAllowed() at the time it is
> supposed not to be called e.g. when LocalXLogInsertAllowed = 0;
> WAL writes are explicitly disabled.

I've pushed 0001 and 0002 but I reversed the order of them and made a
few other edits.

I don't really see the issue you mention here as a problem. There's
only one place where we set LocalXLogInsertAllowed = 0, and I don't
know that we'll ever have another one.

-- 
Robert Haas
EDB: http://www.enterprisedb.com





view thread (197+ messages)  latest in thread

Message-ID: <CA+TgmoZrtgZCTA++wOS+=nXGPhrp6965EZorpRfyvyEpFfdWiQ@mail.gmail.com>
Permalink:  ../CA+TgmoZrtgZCTA++wOS+=nXGPhrp6965EZorpRfyvyEpFfdWiQ@mail.gmail.com/
Also on:    postgresql.org/message-id/CA+TgmoZrtgZCTA++wOS+=nXGPhrp6965EZorpRfyvyEpFfdWiQ@mail.gmail.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: robertmhaas@gmail.com, sulamul@gmail.com, jcasanov@systemguards.com.ec, rushabh.lathia@gmail.com, dilipbalaut@gmail.com, andres@anarazel.de, bharath.rupireddyforpostgres@gmail.com, ibrar.ahmad@gmail.com, prabhat.sahu@enterprisedb.com
  Subject: Re: [Patch] ALTER SYSTEM READ ONLY
  In-Reply-To: <CA+TgmoZrtgZCTA++wOS+=nXGPhrp6965EZorpRfyvyEpFfdWiQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox