public inbox for [email protected]  

help / color / mirror / Atom feed

From: Robert Haas <[email protected]>
To: David Rowley <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: pgsql: Add pg_plan_advice contrib module.
Date: Tue, 17 Mar 2026 09:59:10 -0400
Message-ID: <CA+TgmoZw5tx_Jyxr-KeNAXsPV1yQ4ducgieUxY6+ghd33tCn9Q@mail.gmail.com> (raw)
In-Reply-To: <CAApHDvquH6wnp4fhpaCOkC4R3KAvr2BOTbhhDPDQCBNR3YbLMQ@mail.gmail.com>
References: <[email protected]>
	<CAApHDvquH6wnp4fhpaCOkC4R3KAvr2BOTbhhDPDQCBNR3YbLMQ@mail.gmail.com>

On Mon, Mar 16, 2026 at 5:12 PM David Rowley <[email protected]> wrote:
> I was just building with VS2026 when I noticed the following warning:
>
> ../contrib/pg_plan_advice/pgpa_planner.c(1195): warning C4319: '~':
> zero extending 'uint32' to 'uint64' of greater size
>
> I guess the compiler is concerned that you might not have meant to
> unconditionally switch off all the upper 32-bits of the 64-bit
> variable.  Adding the following does get rid of the warning for me,
> but not sure if that's what you had intended. I've not studied the
> code enough to understand why there are two different integer widths
> being used for the bits.
>
> -               *pgs_mask_p &= ~(PGS_JOIN_ANY & ~join_mask);
> +               *pgs_mask_p &= (uint32) ~(PGS_JOIN_ANY & ~join_mask);

Thanks for the report. This is an error on my part, pure and simple.
At one point, pgs_mask was a 32-bit value, and although that changed
months ago, this holdover escaped detection. I'll go fix that.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgsql: Add pg_plan_advice contrib module.
  In-Reply-To: <CA+TgmoZw5tx_Jyxr-KeNAXsPV1yQ4ducgieUxY6+ghd33tCn9Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox