public inbox for [email protected]  

help / color / mirror / Atom feed

From: David Rowley <[email protected]>
To: Robert Haas <[email protected]>
Cc: [email protected]
Subject: Re: pgsql: Add pg_plan_advice contrib module.
Date: Tue, 17 Mar 2026 10:11:54 +1300
Message-ID: <CAApHDvquH6wnp4fhpaCOkC4R3KAvr2BOTbhhDPDQCBNR3YbLMQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>

On Fri, 13 Mar 2026 at 06:01, Robert Haas <[email protected]> wrote:
> Add pg_plan_advice contrib module.

Hi Robert,

I was just building with VS2026 when I noticed the following warning:

../contrib/pg_plan_advice/pgpa_planner.c(1195): warning C4319: '~':
zero extending 'uint32' to 'uint64' of greater size

I guess the compiler is concerned that you might not have meant to
unconditionally switch off all the upper 32-bits of the 64-bit
variable.  Adding the following does get rid of the warning for me,
but not sure if that's what you had intended. I've not studied the
code enough to understand why there are two different integer widths
being used for the bits.

-               *pgs_mask_p &= ~(PGS_JOIN_ANY & ~join_mask);
+               *pgs_mask_p &= (uint32) ~(PGS_JOIN_ANY & ~join_mask);

David

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: pgsql: Add pg_plan_advice contrib module.
  In-Reply-To: <CAApHDvquH6wnp4fhpaCOkC4R3KAvr2BOTbhhDPDQCBNR3YbLMQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox