public inbox for [email protected]
help / color / mirror / Atom feedFrom: Robert Haas <[email protected]>
To: Lukas Fittl <[email protected]>
Cc: Matheus Alcantara <[email protected]>
Cc: [email protected]
Cc: Tom Lane <[email protected]>
Subject: Re: Add custom EXPLAIN options support to auto_explain
Date: Mon, 6 Apr 2026 15:30:49 -0400
Message-ID: <CA+TgmoaGDHbys0UUzn8hPe9XQJK+HhjsWtqAxpvYJCs6MS1_6g@mail.gmail.com> (raw)
In-Reply-To: <CAP53PkwsnhmoLXJaUMKWc76S21GzYOX06qKyZdVZhGGW0rCWKw@mail.gmail.com>
References: <[email protected]>
<CA+Tgmob-0W8306mvrJX5Urtqt1AAasu8pi4yLrZ1XfwZU-Uj1w@mail.gmail.com>
<CA+TgmoYUdeCdGfk8H6Ni2obXVixLvYaDkRGtxKLEmaCVNffsVA@mail.gmail.com>
<[email protected]>
<CA+TgmoacOujCREMtQwURTSokB+ks-eLgaQ5vBMdWG959XzFcrA@mail.gmail.com>
<CAP53PkwsnhmoLXJaUMKWc76S21GzYOX06qKyZdVZhGGW0rCWKw@mail.gmail.com>
On Fri, Apr 3, 2026 at 10:09 PM Lukas Fittl <[email protected]> wrote:
> Per src/backend/utils/misc/README, "extra is initialized to NULL
> before call, so it can be ignored if not needed." - so we don't have
> to set extra here.
Fair enough, but it's not an uncommon practice. See, e.g.
check_synchronous_standby_names(), check_backtrace_functions().
> You note in a separate comment that we're using a subset of the main
> parser, but maybe its worth calling out integer values in particular,
> since things like "100_000" are not supported (since we're not using
> pg_strtoint64_safe + deal with the complexity of that in the scanning
> logic). I think this could be a code comment for now.
OK, done.
> I think this function probably has the most complexity due to its
> hand-rolled parsing, so it might be good if someone else takes another
> close look at it.
Agreed, but I've committed this for now. If someone finds a problem
later, it can be revised or reverted.
--
Robert Haas
EDB: http://www.enterprisedb.com
view thread (16+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add custom EXPLAIN options support to auto_explain
In-Reply-To: <CA+TgmoaGDHbys0UUzn8hPe9XQJK+HhjsWtqAxpvYJCs6MS1_6g@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox