public inbox for [email protected]  

help / color / mirror / Atom feed

From: Robert Haas <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: Fabien COELHO <[email protected]>
Cc: Hannu Krosing <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Dimitri Fontaine <[email protected]>
Subject: Re: pgbench - adding pl/pgsql versions of tests
Date: Fri, 2 Feb 2024 15:44:12 -0500
Message-ID: <CA+TgmoaO+ZddJg=rSPra8ufpbufoZVKc-juW=9VDLd7Mam2RvQ@mail.gmail.com> (raw)
In-Reply-To: <20230815153423.GB2296544@nathanxps13>
References: <CAMT0RQR1TNSnSWwd65is=HCDjiP4i25mcDDoctEBEiV8351cMQ@mail.gmail.com>
	<20230814150737.GA1395427@nathanxps13>
	<[email protected]>
	<20230815153423.GB2296544@nathanxps13>

On Tue, Aug 15, 2023 at 11:41 AM Nathan Bossart
<[email protected]> wrote:
> Why's that?  I'm not aware of any project policy that prohibits such
> enhancements to pgbench.  It might take some effort to gather consensus on
> a proposal like this, but IMHO that doesn't mean we shouldn't try.  If the
> prevailing wisdom is that we shouldn't add more built-in scripts because
> there is an existing way to provide custom ones, then it's not clear that
> we should proceed with $SUBJECT, anyway.

I don't think there's a policy against adding more built-in scripts to
pgbench, but I'm skeptical of such efforts because I don't see how to
decide which ones are worthy of inclusion and which are not. Adding
everyone's favorite thing will be too cluttered, and adding nothing
forecloses nothing because people can always provide their own. If we
could establish that certain custom scripts are widely used across
many people, then those might be worth adding.

I have a vague recollection of someone proposing something similar to
this in the past, possibly Jeff Davis. If there is in fact a paper
trail showing that the same thing has been proposed more than once by
unrelated people, that would be a point in favor of adding that
particular thing.

-- 
Robert Haas
EDB: http://www.enterprisedb.com

view thread (14+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pgbench - adding pl/pgsql versions of tests
  In-Reply-To: <CA+TgmoaO+ZddJg=rSPra8ufpbufoZVKc-juW=9VDLd7Mam2RvQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox