public inbox for [email protected]  

help / color / mirror / Atom feed

From: Robert Haas <[email protected]>
To: Greg Burd <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: Masahiko Sawada <[email protected]>
Subject: Re: [PATCH] Add tests for Bitmapset
Date: Wed, 17 Sep 2025 09:55:12 -0400
Message-ID: <CA+TgmobSF4J_JWKdX=MWbG134Bn3OZ8LJyBP-_RQCykB=geaJw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On Wed, Sep 17, 2025 at 9:18 AM Greg Burd <[email protected]> wrote:
> > +static void
> > +elog_bitmapset(int elevel, const char *label, const Bitmapset *bms)
> >
>
> I added a function bms_values() that prints out the values contained in
> a bitmapset and changed a few tests to use it.  I removed the
> elog_bitmapset() as it isn't being used and now that it's easy to output
> the set in SQL why keep it for debugging?

How about using outBitmapset() which already exists?

-- 
Robert Haas
EDB: http://www.enterprisedb.com

view thread (81+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Add tests for Bitmapset
  In-Reply-To: <CA+TgmobSF4J_JWKdX=MWbG134Bn3OZ8LJyBP-_RQCykB=geaJw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox