public inbox for [email protected]  

help / color / mirror / Atom feed

From: Imran Zaheer <[email protected]>
To: pgsql-hackers <[email protected]>
Subject: Remove commented-out code in 026_overwrite_contrecord.pl
Date: Fri, 3 Apr 2026 18:56:01 +0500
Message-ID: <CA+UBfa=qqnpx-B_dTy4KCYEyXCmST_Zv9X1DL3Yw0mccmzOaaQ@mail.gmail.com> (raw)

Hi

There is some unused commented line of code in the tap test file `
026_overwrite_contrecord.pl` [1]. Looks like a left over from earlier test
development.

Remove it for clarity.

Thanks,
Imran Zaheer

[1]:
https://github.com/postgres/postgres/blob/b7b27eb41a5cc0b45a1a9ce5c1cde5883d7bc358/src/test/recovery...


Attachments:

  [text/x-patch] v1-0001-Remove-commented-code-in-026_overwrite_contrecord.patch (1.1K, 3-v1-0001-Remove-commented-code-in-026_overwrite_contrecord.patch)
  download | inline diff:
From 5eedaf7fd3c69516091a53ee281056320d3f5b21 Mon Sep 17 00:00:00 2001
From: Imran Zaheer <[email protected]>
Date: Fri, 3 Apr 2026 18:31:03 +0500
Subject: [PATCH v1] Remove commented code in 026_overwrite_contrecord

This commented-out CREATE TABLE statement appears to be a leftover from
earlier test development and is not used in the test. Remove it for clarity.
---
 src/test/recovery/t/026_overwrite_contrecord.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/test/recovery/t/026_overwrite_contrecord.pl b/src/test/recovery/t/026_overwrite_contrecord.pl
index 4f501169f42..82567ca6bfc 100644
--- a/src/test/recovery/t/026_overwrite_contrecord.pl
+++ b/src/test/recovery/t/026_overwrite_contrecord.pl
@@ -58,7 +58,7 @@ my $initfile = $node->safe_psql('postgres',
 $node->safe_psql('postgres',
 	qq{SELECT pg_logical_emit_message(true, 'test 026', repeat('xyzxz', 123456))}
 );
-#$node->safe_psql('postgres', qq{create table foo ()});
+
 my $endfile = $node->safe_psql('postgres',
 	'SELECT pg_walfile_name(pg_current_wal_insert_lsn())');
 ok($initfile ne $endfile, "$initfile differs from $endfile");
-- 
2.34.1

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected]
  Subject: Re: Remove commented-out code in 026_overwrite_contrecord.pl
  In-Reply-To: <CA+UBfa=qqnpx-B_dTy4KCYEyXCmST_Zv9X1DL3Yw0mccmzOaaQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox